The WebIDL conversions shouldn't throw on detached buffers #12534
Comments
|
UB is no longer an issue with denoland/rusty_v8#809. |
andreubotella
pushed a commit
to andreubotella/deno
that referenced
this issue
Oct 28, 2021
The Web IDL conversion to `BufferSource` and similar types shouldn't check whether the buffer is detached. In the case of `TextDecoder`, our implementation would still throw after the Web IDL conversions because we're creating a new `Uint8Array` from the buffer source's buffer, which throws if it's detached. This change also fixes this bug. Fixes denoland#12534.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See jsdom/webidl-conversions#29.
This is causing the failure of the following WPT tests:
encoding/encodeInto.any.html,encoding/encodeInto.any.worker.html: "encodeInto()and a detached output buffer"encoding/streams/decode-utf8.any.html,encoding/streams/decode-utf8.any.html: "decoding a transferredUint8Arraychunk should give no output", "decoding a transferredArrayBufferchunk should give no output"serde_v8does the right thing when constructing aZeroCopyBufand correctly derefs to an empty slice. Constructing that empty slice might be UB, though, but that is a more general problem than for detached buffers: see denoland/rusty_v8#711 (comment)The text was updated successfully, but these errors were encountered: