Auto clean failed with error

[denven]

[denven]

When it started to clean spaces, it failed when some errors happened. Currently, it happened to my subscribed OneDrive account and works for my personal account

[denven]

from the error message, jq failed to index string "message", which means the api request returned non-desirable data which doesn't contain the path of error.message in function send_api_request() or refresh_oauth2_tokens(), and it may result in:

• ./data/token.json file corrupted
• get_percent() failure on the wrong calculation and starting auto_clean improperly

the following code cannot test if the variable ${total} is 0, it only tests if it is not empty. get_percent() has a chance to run into an exception error Division by zero

if [ ! -z ${total} ]; then 
	used_ratio=$(get_percent ${used} ${total})
	free_ratio=$(get_percent ${remaining} ${total})
else 
	continue
fi 

To fix this issue, we have to find what the API response looks like when it happens. Currently, wait for another time to reproduce and fix it.

[denven]

Sometimes, the refreshing access token will fail and leads to wrong and invalid data being written into the data/token.json file, checked MS OAuth2 API, the error message doesn't contain a nested 'errror.message' path, so fetching the error message by jq from this key path will break.

Once this API returns an error and continues, acces_token may fail to expire eventually, then manual re-authorization is required to fix this issue due to the continuous failure of refresh tokens.

[denven]

Fixed