diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 7f0702634..9e741f22f 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2024-09-03 23:47:59 UTC using RuboCop version 1.59.0. +# on 2024-10-03 23:29:44 UTC using RuboCop version 1.59.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -37,14 +37,14 @@ Capybara/CurrentPathExpectation: - 'spec/features/terms_and_conditions_spec.rb' - 'spec/features/users/user_profile_spec.rb' -# Offense count: 311 +# Offense count: 301 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: have_no, not_to Capybara/NegationMatcher: Enabled: false -# Offense count: 128 +# Offense count: 129 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: DefaultSelector. Capybara/RSpec/HaveSelector: @@ -56,7 +56,7 @@ Capybara/SpecificActions: - 'spec/features/crh_spec.rb' - 'spec/features/shared/breadcrumbs_spec.rb' -# Offense count: 194 +# Offense count: 195 # This cop supports safe autocorrection (--autocorrect). Capybara/SpecificFinders: Enabled: false @@ -67,7 +67,7 @@ Capybara/SpecificMatcher: - 'spec/features/practice_editor/implementation/practice_resources_spec.rb' - 'spec/features/practice_editor/introduction/introduction_spec.rb' -# Offense count: 89 +# Offense count: 90 Capybara/VisibilityMatcher: Enabled: false @@ -106,7 +106,7 @@ Lint/AmbiguousOperator: - 'app/admin/pages.rb' - 'app/admin/practices.rb' -# Offense count: 3 +# Offense count: 4 # This cop supports safe autocorrection (--autocorrect). Lint/AmbiguousOperatorPrecedence: Exclude: @@ -192,18 +192,17 @@ Lint/RedundantDirGlobSort: Exclude: - 'spec/spec_helper.rb' -# Offense count: 8 +# Offense count: 7 # This cop supports safe autocorrection (--autocorrect). Lint/RedundantStringCoercion: Exclude: - 'app/admin/editor/pages.rb' - - 'app/admin/homepage.rb' - 'app/admin/pages.rb' - 'app/admin/site_metrics.rb' - 'app/helpers/application_helper.rb' - 'lib/tasks/va_facilities.rake' -# Offense count: 10 +# Offense count: 7 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowedMethods. # AllowedMethods: present?, blank?, presence, presence_in, try, try!, in? @@ -211,7 +210,6 @@ Lint/SafeNavigationChain: Exclude: - 'app/admin/editor/pages.rb' - 'app/admin/pages.rb' - - 'app/controllers/home_controller.rb' - 'lib/tasks/importer.rake' # Offense count: 74 @@ -240,7 +238,7 @@ Lint/UnderscorePrefixedVariableName: - 'app/models/page_component.rb' - 'app/models/user.rb' -# Offense count: 38 +# Offense count: 37 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments. Lint/UnusedBlockArgument: @@ -253,6 +251,7 @@ Lint/UnusedBlockArgument: - 'config/initializers/commontator.rb' - 'lib/classes/params.rb' - 'lib/tasks/importer.rake' + - 'spec/factories/homepages.rb' - 'spec/features/pages/event_component_spec.rb' - 'spec/features/practice_editor/overview/video_spec.rb' @@ -321,12 +320,12 @@ Metrics/BlockNesting: Metrics/ClassLength: Max: 405 -# Offense count: 56 +# Offense count: 57 # Configuration parameters: AllowedMethods, AllowedPatterns. Metrics/CyclomaticComplexity: Max: 78 -# Offense count: 182 +# Offense count: 181 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns. Metrics/MethodLength: Max: 224 @@ -430,17 +429,18 @@ Performance/MapCompact: - 'app/admin/users.rb' - 'app/models/diffusion_history_status.rb' -# Offense count: 11 +# Offense count: 10 # This cop supports safe autocorrection (--autocorrect). Performance/RedundantSplitRegexpArgument: Exclude: - 'lib/tasks/importer.rake' -# Offense count: 19 +# Offense count: 21 # This cop supports safe autocorrection (--autocorrect). Performance/RedundantStringChars: Exclude: - 'app/models/concerns/text_and_image_component.rb' + - 'app/models/homepage_feature.rb' - 'app/models/page_component_image.rb' - 'app/models/page_event_component.rb' - 'app/models/page_header2_component.rb' @@ -549,7 +549,7 @@ RSpec/EmptyLineAfterHook: - 'spec/requests/page_resources_controller_spec.rb' - 'spec/tasks/importer_spec.rb' -# Offense count: 366 +# Offense count: 370 # Configuration parameters: CountAsOne. RSpec/ExampleLength: Max: 232 @@ -594,7 +594,7 @@ RSpec/HookArgument: Exclude: - 'spec/rails_helper.rb' -# Offense count: 147 +# Offense count: 141 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: is_expected, should @@ -613,7 +613,7 @@ RSpec/IndexedLet: - 'spec/models/va_facility_spec.rb' - 'spec/services/practice_mailer_service_spec.rb' -# Offense count: 1684 +# Offense count: 1698 # Configuration parameters: AssignmentOnly. RSpec/InstanceVariable: Enabled: false @@ -632,7 +632,7 @@ RSpec/LetSetup: RSpec/MetadataStyle: Enabled: false -# Offense count: 499 +# Offense count: 503 RSpec/MultipleExpectations: Max: 96 @@ -676,7 +676,12 @@ RSpec/NoExpectationExample: RSpec/NotToNot: Enabled: false -# Offense count: 162 +# Offense count: 3 +RSpec/PendingWithoutReason: + Exclude: + - 'spec/features/shared/header_spec.rb' + +# Offense count: 160 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: Inferences. RSpec/Rails/InferredSpecType: @@ -867,7 +872,7 @@ Rails/EnvironmentComparison: Exclude: - 'config/initializers/opentelemetry.rb' -# Offense count: 72 +# Offense count: 73 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: slashes, arguments @@ -918,7 +923,7 @@ Rails/HttpStatus: Exclude: - 'app/controllers/errors_controller.rb' -# Offense count: 25 +# Offense count: 26 Rails/I18nLocaleTexts: Exclude: - 'app/admin/categories.rb' @@ -927,6 +932,7 @@ Rails/I18nLocaleTexts: - 'app/admin/page_group.rb' - 'app/admin/practices.rb' - 'app/controllers/application_controller.rb' + - 'app/controllers/home_controller.rb' - 'app/controllers/nominate_practices_controller.rb' - 'app/controllers/practices_controller.rb' - 'app/controllers/session_timeout_controller.rb' @@ -1011,12 +1017,11 @@ Rails/PluralizationGrammar: - 'spec/features/admin/admin_adoptions_spec.rb' - 'spec/features/admin/site_metrics_spec.rb' -# Offense count: 10 +# Offense count: 8 # This cop supports safe autocorrection (--autocorrect). Rails/Presence: Exclude: - 'app/admin/editor/page_group.rb' - - 'app/admin/homepage.rb' - 'app/admin/page_group.rb' - 'app/controllers/practices_controller.rb' - 'app/controllers/va_facilities_controller.rb' @@ -1062,7 +1067,7 @@ Rails/RequestReferer: Exclude: - 'app/controllers/practices_controller.rb' -# Offense count: 13 +# Offense count: 16 # Configuration parameters: Include. # Include: db/**/*.rb Rails/ReversibleMigration: @@ -1073,6 +1078,7 @@ Rails/ReversibleMigration: - 'db/migrate/20240718220057_drop_badge_practices_and_badges_tables.rb' - 'db/migrate/20240725224021_drop_topics.rb' - 'db/migrate/20240819013959_drop_retired_file_models.rb' + - 'db/migrate/20240920234630_drop_retired_importer_models.rb' # Offense count: 17 # This cop supports unsafe autocorrection (--autocorrect-all). @@ -1095,10 +1101,10 @@ Rails/RootPathnameMethods: # ForbiddenMethods: decrement!, decrement_counter, increment!, increment_counter, insert, insert!, insert_all, insert_all!, toggle!, touch, touch_all, update_all, update_attribute, update_column, update_columns, update_counters, upsert, upsert_all Rails/SkipsModelValidations: Exclude: - - 'app/admin/homepage.rb' - 'app/controllers/users_controller.rb' - 'app/models/commontator/comment.rb' - 'app/models/commontator/thread.rb' + - 'app/models/homepage.rb' - 'app/services/practice_mailer_service.rb' - 'db/migrate/20230927000910_add_service_name_to_active_storage_blobs.active_storage.rb' - 'db/migrate/20231127172710_add_public_to_pages.rb' @@ -1116,7 +1122,7 @@ Rails/SquishedSQLHeredocs: Rails/ThreeStateBooleanColumn: Enabled: false -# Offense count: 302 +# Offense count: 303 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle. # SupportedStyles: strict, flexible