Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utils: Update phonenumbers package 8.12.x to 8.13.x #143

Open
5 tasks
EvanParish opened this issue Oct 10, 2023 · 3 comments
Open
5 tasks

Utils: Update phonenumbers package 8.12.x to 8.13.x #143

EvanParish opened this issue Oct 10, 2023 · 3 comments

Comments

@EvanParish
Copy link

EvanParish commented Oct 10, 2023

User Story - Business Need

There is a dependabot PR (see Potential Dependencies) to update the phonenumbers package in the api repo, but first the package needs to be updated in this repo. There is a test that fails when the package is updated.

Note (added Jan 2025): phonenumbers is set to an asterisk in the API pyproject.toml file but in looking at the lock file, it is set below 8.13.x. The dependabot issue is no longer open, also, in API. It is still open in the utils repo, so this ticket should still be worked.

The failing test over in Utils is as follows:

Image

  • Ticket is understood, and QA has been contacted (if the ticket has a QA label).

User Story(ies)

As a va notify engineer
I want to update dependencies
So that we have an up-to-date and secure platform.

Additional Info and Resources

This is the failing test in the utils repo:

______ test_format_local_and_international_phone_numbers[+20-12-1234-1234-+20 121 234 1234] _______
[gw0] linux -- Python 3.8.16 /home/evan/.pyenv/versions/3.8.16/envs/utils-venv/bin/python3.8

phone_number = '+20-12-1234-1234', expected_formatted = '+20 121 234 1234'

>   ???
E   AssertionError: assert '+20 12 12341234' == '+20 121 234 1234'
E     - +20 121 234 1234
E     + +20 12 12341234

/home/evan/dev/va/notification-utils/tests/test_recipient_validation.py:419: AssertionError
===== short test summary info =====
FAILED tests/test_recipient_validation.py::test_format_local_and_international_phone_numbers[+20-12-1234-1234-+20 121 234 1234] - AssertionError: assert '+20 12 12341234' == '+20 121 234 1234'
===== 1 failed, 1364 passed, 76 skipped, 41 xfailed

Engineering Checklist

  • ONLY update phonenumbers not all dependencies
  • Update the phonenumbers package from v8.12.57 to v8.13.x in the Utils repo so the dependabot issue can be cleared
  • Fix failing unit tests
  • Validate with API deploy of this work

Acceptance Criteria

  • All tests pass in the utils repo and the api repo
  • No functionality is affected

QA Considerations

  • Check that Dependabot issue is cleared
  • Run regression in Perf

Out of Scope

this ticket is just to update phonenumbers, not every dependency in utils

@mjones-oddball
Copy link

@npmartin-oddball
Copy link

Still needed.

@cris-oddball
Copy link

No more dependabot issues, probably because dependabot doesn't look in the utils setup.py. Still needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants