Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENP Docker overhaul #125

Open
8 tasks
cris-oddball opened this issue Jan 3, 2025 · 1 comment
Open
8 tasks

ENP Docker overhaul #125

cris-oddball opened this issue Jan 3, 2025 · 1 comment
Labels
Dev Reviewed Reviewed by Tech Lead Notify Board trigger PM Reviewed Reviewed by Product Manager QA Reviewed Reviewed by Quality Assurance QA Issue requires QA collaboration

Comments

@cris-oddball
Copy link
Contributor

cris-oddball commented Jan 3, 2025

User Story - Business Need

Whilst performing other work, there appear to be problems with the way the container is Dockerized. This ticket aims to overhaul that container and documentation.

  • Ticket is understood, and QA has been contacted (if the ticket has a QA label).

User Story(ies)

As a VA ENP dev
I want a consistent, repeatable Docker container
So that development is simplified

Additional Info and Resources

Issue 1: the Poetry version is pinned down to 1.8.3 when we upgraded to 1.8.4 within the last three months.
Issue 2: Kyle had issues running the existing container (see him for details).
Issue 3: bash is not in the Docker build but the script runs bash
Image

Acceptance Criteria

  • the ENP docker container is overhauled for consistency
  • Docker locks it to Poetry 1.8.5
  • if a bash script is to be run, then bash must be in the $PATH, or clear documentation is included for how the script runs
  • Issues discovered from the GHA Deploy ticket are addressed (such as cert/port/etc.)
  • Documentation is updated
  • This work is added to the sprint review slide deck (key win bullet point and demo slide)

QA Considerations

  • Validate all work performed.

Potential Dependencies

This work is dependent on the ability to deploy images.
The task needs to be running and the load balancer needs to point to it.

@cris-oddball cris-oddball added Notify Board trigger QA Issue requires QA collaboration QA Reviewed Reviewed by Quality Assurance labels Jan 3, 2025
@kbelikova-oddball kbelikova-oddball added the PM Reviewed Reviewed by Product Manager label Jan 6, 2025
@k-macmillan k-macmillan added the Dev Reviewed Reviewed by Tech Lead label Jan 6, 2025
@k-macmillan
Copy link
Member

k-macmillan commented Jan 22, 2025

Need to re-evaluate if necessary.
Discussed with the dev that recently overhauled the container. We want to keep this until after the container has been deployed because we expect some wrinkles that will need to be ironed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev Reviewed Reviewed by Tech Lead Notify Board trigger PM Reviewed Reviewed by Product Manager QA Reviewed Reviewed by Quality Assurance QA Issue requires QA collaboration
Projects
None yet
Development

No branches or pull requests

4 participants