feat(system): Dropdown 컴포넌트 구현 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qkrdmstlr3
requested review from
woo-jk,
Collection50 and
eunbeann
as code owners
❌ Deploy Preview for bbogak failed.
|
qkrdmstlr3
force-pushed
the
feat/system/dropdown
branch
from
bf9b3c1 to
5ff2f3e
Compare
woo-jk
reviewed
Aug 20, 2024
Comment on lines
14
to
28
| export const CheckboxItem = forwardRef<HTMLButtonElement, Props>(function CheckboxItem( | ||
| { checked, disabled, children, ...restProps }, | ||
| ref, | ||
| ) { | ||
| const { styles, logics } = useDropdownContext(); | ||
|
|
||
| return ( | ||
| <button ref={ref} disabled={disabled} {...mergeProps(styles['checkbox-item'], logics['checkbox-item'], restProps)}> | ||
| {children} | ||
| <If condition={checked}> | ||
| <Icon name="check" color={color.neutral30} size={20} /> | ||
| </If> | ||
| </button> | ||
| ); | ||
| }); |
There was a problem hiding this comment.
Dropdown에 Checkbox가 필요한 이유에 대해 고민한 시간이 존재했습니다.
이후 영상을 보고 어떤 컴포넌트인지 파악했어요
CheckedItem이라는 이름은 어떨까요??
코멘트 수준으로 남겨드립니다 👍
| separator: {}, | ||
| 'trigger-arrow': {}, | ||
| 'checkbox-item': { | ||
| onClick: () => onOpenChange(false), |
There was a problem hiding this comment.
chain을 사용해서 onClick을 체이닝하는 것이 좋다고 생각합니다 !
임의로 추가되는 onClick에 대해서도 대응하면 좋을 것 같아요 👍
There was a problem hiding this comment.
컴포넌트 단계에서 mergeProps로 합쳐주고 있어요!
Collection50
approved these changes
Aug 21, 2024
eunbeann
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
이건 나눠진 리스트에 divider 쓸 때 필요한거죠??
|
PR예제 본문에 첨부했습니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3. 관련 스크린샷을 첨부해주세요.
2024-08-21.1.29.50.mov
4. 완료 사항
5. 추가 사항 / 코드 리뷰 받고 싶은 부분