feat(login): 구글 로그인 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collection50
requested review from
qkrdmstlr3,
woo-jk and
eunbeann
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
woo-jk
reviewed
Aug 30, 2024
src/app/login/components/Login.tsx
Outdated
| { provider: 'GOOGLE', token: res.access_token }, | ||
| { | ||
| onSuccess: ({ data: { isFirstLogin, accessToken, refreshToken } }) => { | ||
| const jobSelection = isFirstLogin ? SELECT : NONE; |
There was a problem hiding this comment.
NONE과 SELECT가 반대로 되어야 할 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. 무슨 이유로 코드를 변경했나요?
2. 어떤 위험이나 장애를 발견했나요?
3. 관련 스크린샷을 첨부해주세요.
4. 완료 사항
5. 추가 사항 / 코드 리뷰 받고 싶은 부분