feat: 비동기 처리를 위한 유틸 함수 구현 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collection50
requested review from
qkrdmstlr3,
woo-jk and
eunbeann
as code owners
eunbeann
approved these changes
Jul 19, 2024
woo-jk
approved these changes
Jul 19, 2024
src/hooks/useIsClient/index.ts
Outdated
Comment on lines
6
to
10
| return useSyncExternalStore( | ||
| () => () => {}, | ||
| () => true, | ||
| () => false, | ||
| ); |
| type ErrorBoundaryProps<ErrorType extends Error = Error> = { | ||
| onReset?(): void; | ||
| renderFallback: RenderFallbackType | FallbackType; | ||
| onError?(error: ErrorType, info: ErrorInfo): void; |
There was a problem hiding this comment.
info 인자는 옵셔널하게 받아도 괜찮지 않을까요?!
* tailwind 컬러 팔레트 설정 * mint -> lime 네이밍 변경 * palette 변경된 요소 반영
* tailwind 컬러 팔레트 설정 * mint -> lime 네이밍 변경 * palette 변경된 요소 반영
* tailwind 컬러 팔레트 설정 * mint -> lime 네이밍 변경 * palette 변경된 요소 반영
* tailwind 컬러 팔레트 설정 * mint -> lime 네이밍 변경 * palette 변경된 요소 반영
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. 무슨 이유로 코드를 변경했나요?
Suspense,ErrorBoundary,AsyncBoundary를 구현했습니다.generateContext함수를 구현했습니다.shadcn-ui를 추가했습니다.2. 어떤 위험이나 장애를 발견했나요?
3. 관련 스크린샷을 첨부해주세요.
4. 완료 사항
Suspense,Asyncboundary,ErrorBoundary,generateContext유틸 함수 생성 (159d4e2)5. 추가 사항 / 코드 리뷰 받고 싶은 부분