Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate Result/AxeResults to one class/package #389

Open
bdschultzAU opened this issue Nov 6, 2023 · 2 comments
Open

Consolidate Result/AxeResults to one class/package #389

bdschultzAU opened this issue Nov 6, 2023 · 2 comments
Labels

Comments

@bdschultzAU
Copy link

Is it possible to consolidate these two classes into one? I'm in a situation where my organization uses axe for selenium & playwright and we have a shared library for managing results with both.

playwright: com.deque.html.axecore.results.AxeResults
selenium: com.deque.html.axecore.results.Results

I saw that AxeRunOptions was consolidated in a similar manner.

@Zidious
Copy link
Contributor

Zidious commented Nov 6, 2023

Hey @bdschultzAU,

I think overall that's a good direction to go down. We couldn't directly change the return signature from AxeResults.class to Result.class as part of analyze() as that would be classed as a breaking change, that change would need to wait for 5.0 which is quite a while out.

Is this something that's urgent, or more of a tedious juggle between the two?

@bdschultzAU
Copy link
Author

It would be a nice-to-have, allowing us to simplify the code. I used generics to allow both to work with our parent class for now. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants