Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPIC: gha comparison logic #115

Open
2 of 5 tasks
dequejenn opened this issue Sep 27, 2023 · 3 comments
Open
2 of 5 tasks

EPIC: gha comparison logic #115

dequejenn opened this issue Sep 27, 2023 · 3 comments
Labels
jazzband Ticket about jazzband project team-bass Bass team ticket TYPE: task Ticket is for non-dev work

Comments

@dequejenn
Copy link
Contributor

dequejenn commented Sep 27, 2023

When the GHA is ran, it is not taking into account the comparisons like it should. The below tickets will correct this logic error.

TODO - the above logic needs to be changed a bit to reflect comparing to the common ancestor commit of the base branch, NOT the default branch. In order to do this, we will need to be grabbing the base branch from the git info and saving that as well as default branch info per commit. These tickets are on hold until this is thought out a bit further and the corresponding tickets are modified** EDIT: we are only comparing to the last scan of the default branch. We are trying to answer the question "how does my commit affect the current accessibility of the default branch?" so comparing to the last commit is the correct way to answer thing. No need to find a common ancenstor

Tasks

  1. QA: hold for epic TYPE: task blocked jazzband team-bass
@dequejenn dequejenn added TYPE: task Ticket is for non-dev work PRIORITY: high High priority item; should be scheduled in this or next sprint QA: required This ticket requires QA signoff jazzband Ticket about jazzband project next up Ticket is groomed for next sprint labels Sep 27, 2023
@dequejenn dequejenn added in sprint Ticket is in current sprint and removed next up Ticket is groomed for next sprint labels Sep 28, 2023
@dequejenn dequejenn changed the title Make URL show comparison to default branch or last commit EPIC: gha comparison logic Nov 6, 2023
@dequejenn
Copy link
Contributor Author

dequejenn commented Dec 7, 2023

This was overkill and may be done later. However, for now, we just fixed the link to always show to commit to commit comparison so moving this to inactive epic for the moment

@dequejenn dequejenn removed in sprint Ticket is in current sprint PRIORITY: high High priority item; should be scheduled in this or next sprint QA: required This ticket requires QA signoff labels Dec 7, 2023
@dequejenn dequejenn added the team-bass Bass team ticket label Jun 20, 2024
@ballendq
Copy link

ballendq commented Jul 1, 2024

@dequejenn still a bit confused by this ticket. I think we need to do some editing. My understanding is that:

  1. The problem to be solved: make the GHA comparison meaningful. In other words, compare the accessibility of the latest commit in the pull request with that of the default branch in order to answer the question "does this PR make my UI more or less accessible?"
  2. This only applies to the GHA, not other aspects of the UI/UX.
  3. Solution concerns I have - how do we get the accessibility data associated with the "main branch" if we haven't run DevHub against a commit within that branch? I'm still a bit confused on this point, and I'm not sure what I'm missing.

@dequejenn
Copy link
Contributor Author

@ballendq

  1. Yes
  2. Yes
  3. Look at the details of this ticket. This is all of the use cases with behavior for each verified by Dylan in this thread

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jazzband Ticket about jazzband project team-bass Bass team ticket TYPE: task Ticket is for non-dev work
Projects
None yet
Development

No branches or pull requests

3 participants