Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow failing in middle cause i have violations in my test but i don't want test to fail in middle #160

Open
PavanMudigondaTR opened this issue Oct 1, 2024 · 1 comment
Assignees

Comments

@PavanMudigondaTR
Copy link

I am running with provided action step and its failing with exit code 1. I don't want work flow to fail in middle. I reviewed your shell script and found this line 90 is causing it

if [ "$LastRunViolationCount" -gt 0 ]; then

I would appreciate if you can add a quality gate/flag similar to ENABLE_A11Y_THRESHOLD.

Found 30 accessibility violations
Error: Process completed with exit code 1.
Run marocchino/sticky-pull-request-comment@v2
no pull request numbers given: skip step

image
@Zidious
Copy link
Contributor

Zidious commented Oct 10, 2024

Hey @PavanMudigondaTR,

Apologies for the delayed reply.

If I'm understanding the issue correctly you either have subsequent jobs that run after the watcher job has completed and want those to continue and not fail fast.

I would suggest using GitHub's inbuilt continue-on-error (docs). When this value is set to true it will not fail your devhub job.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants