Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ❇️ added codeoweners and updated deps #2

Merged
merged 1 commit into from
May 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 64 additions & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
# ==================================================================================
# ==================================================================================
# Deriv CODEOWNERS
# ==================================================================================
# ==================================================================================
#
# Configuration of code ownership and review approvals for the deriv-com/bot repo.
#
# More info: https://help.github.com/articles/about-codeowners/
#


# ================================================
# General rules / philosophy
# ================================================
#
# - we trust that people do the right thing and not approve changes they don't feel confident reviewing
# - we use github teams so that we funnel code reviews to the most appropriate reviewer, this is why the team structure is fine-grained
# - we enforce that only approved PRs get merged to ensure that unreviewed code doesn't get accidentally merged
# - we delegate approval rights as much as possible so that we can scale better
# - each group must have at least one person, but several people are preferable to avoid a single point of failure issues
#
# Configuration nuances:
#
# - This configuration works in conjunction with the protected branch settings that require all changes to be made via pull requests with at least one approval.
# - This approval can come from an appropriate codeowner, or any repo collaborator (person with write access) if the PR is authored by a codeowner.
# - Each codeowners team must have write access to the repo, otherwise their reviews won't count.
#
# In the case of emergency, the repo administrators can bypass this requirement.



# ================================================
# GitHub username registry
# (just to make this file easier to understand)
# ================================================

# ali-hosseini-deriv
# yashim-deriv
# wojciech-deriv
# markwylde-deriv
# balakrishna-deriv
# sandeep-deriv
# shafin-deriv

######################################################################################################
#
# CODEOWNERS rules
# -----------------
#
# All the following rules are applied in the order specified in this file.
# The last rule that matches wins!
#
# See https://git-scm.com/docs/gitignore#_pattern_format for pattern syntax docs.
#
######################################################################################################


# ==============================================================
# Default Owners
# (in case no pattern matches a path in a PR - this should be treated as a bug and result in adding the path to CODEOWNERS)
# ==============================================================

* @ali-hosseini-deriv @yashim-deriv @wojciech-deriv @markwylde-deriv @balakrishna-deriv @sandeep-deriv @shafin-deriv
10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,10 @@
"mobx": "^6.12.3",
"mobx-react-lite": "^4.0.7",
"react": "^18.2.0",
"react-dom": "^18.2.0"
"react-dom": "^18.2.0",
"vite": "^5.1.4",
"vite-plugin-svgr": "^4.2.0",
"@vitejs/plugin-react": "^4.2.1"
},
"devDependencies": {
"@babel/plugin-proposal-class-properties": "^7.18.6",
Expand All @@ -52,7 +55,6 @@
"@types/react-dom": "^18.2.19",
"@typescript-eslint/eslint-plugin": "^6.12.0",
"@typescript-eslint/parser": "^6.0.0",
"@vitejs/plugin-react": "^4.2.1",
"eslint": "^8.56.0",
"eslint-plugin-prettier": "^5.0.0",
"eslint-plugin-react-hooks": "^4.6.0",
Expand All @@ -73,8 +75,6 @@
"stylelint-no-unsupported-browser-features": "^4.0.0",
"stylelint-selector-bem-pattern": "^4.0.0",
"ts-jest": "^29.1.2",
"typescript": "^5.2.2",
"vite": "^5.1.4",
"vite-plugin-svgr": "^4.2.0"
"typescript": "^5.2.2"
}
}
2 changes: 1 addition & 1 deletion src/pages/home/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export default function Home() {

return (
<Fragment>
<div>Home Page</div>
<div>Deriv-Bot&apos;s new Home!</div>
<Dashboard />
</Fragment>
);
Expand Down
Loading