Rupato/check remove child error #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rupato-deriv
requested review from
sandeep-deriv and
shafin-deriv
as code owners
|
Preview Link: https://Rupato-Check-removec.bot-65f.pages.dev
|
shafin-deriv
approved these changes
Dec 13, 2024
farabi-deriv
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on improving the robustness of element removal in various parts of the codebase by ensuring the parent element contains the child element before attempting to remove it. The most important changes include modifications in multiple files to implement this check.
Element removal improvements:
src/components/shared_ui/modal/modal.tsx: Added checks to ensure the parent element contains the child element before removing it in theModalElementcomponent.src/constants/load-modal.ts: Enhanced theclearInjectionDivfunction by adding checks to ensure the parent element contains the child element before removal.src/external/bot-skeleton/scratch/backward-compatibility.js: Updated theBlockConversionclass to include checks before removing child elements in two different locations. [1] [2]src/external/bot-skeleton/scratch/goog.js: Modified thegoog.dom.removeNodefunction to ensure the parent element contains the child element before removal.src/pages/tutorials/tutorials-tab-mobile.tsx: Added checks in theTutorialsTabMobilecomponent to ensure the parent element contains the child element before removing it.