Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WALL] george / WALL-5235 / Notification Missing on Trader’s Hub Page for Wallet Accounts #17802

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

heorhi-deriv
Copy link
Contributor

Changes:

  • add popup notification functionality into wallets

Screenshots:

Screenshot 2024-12-11 at 13 53 23 Screenshot 2024-12-11 at 13 53 40

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 11, 2024 11:24am

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12274993883

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on WALL-5235-Notification-Missing-on-Trader’s-Hub-Page-for-Wallet-Accounts at 53.91%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/src/App/Containers/RootComponent/root-component.jsx 0 1 0.0%
Totals Coverage Status
Change from base Build 12274043819: 53.9%
Covered Lines: 32988
Relevant Lines: 57038

💛 - Coveralls

Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17802](https://github.com/deriv-com/deriv-app/pull/17802)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-heorhi-deriv-wall-5235-notification-m-5479ed.binary.sx?qa_server=red.derivws.com&app_id=31584
    - **Original**: https://deriv-app-git-fork-heorhi-deriv-wall-5235-notification-m-5479ed.binary.sx
- **App ID**: `31584`

Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 30
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-heorhi-deriv-wall-5235-notification-m-5479ed.binary.sx/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants