Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add filter to undefined properties before sending to SDK-CORE #229

Closed

Conversation

manfioLP
Copy link

Related Issues

Possibly Fixes #228
Just a Suggestion PR

Description

Make it possible to update just one property of a User without having to fullfil all parameters in order

Must

  • Tests
  • Documentation (if applicable)

Known Issues

  • It wont let update a property to undefined values
  • Needs further testing that wasn't made since core-js-sdk isn't public
  • It's not yet a batch update, better way was to change the function signature (needs further validation on prod impacts)

@manfioLP manfioLP mentioned this pull request Jul 10, 2023
@dorsha dorsha requested a review from shilgapira July 11, 2023 06:27
@shilgapira
Copy link
Member

Thanks for your contribution, really appreciated! I'll go over this today and ping you back 👍

@itaihanski
Copy link
Member

itaihanski commented Jul 11, 2023

@manfioLP Thanks for your suggestion. I understand you want to update part of the user object. To do that we’ll need to expose a PATCH method for you so you can update specific properties of the user. Otherwise properties that are left as undefined will just get removed by the update.

So far, our approach to selective user updates has been to expose specific functions, like updateCustomAttribute which you have used.

We’ll take issue #228 into consideration and hopefully have a more streamlined solution for you to use in a short while.

@shilgapira
Copy link
Member

We've added support for patch user to the Node SDK, so I'm closing this now. 👍

@shilgapira shilgapira closed this Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating User
3 participants