Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Options to Something Else? #12

Closed
ghost opened this issue Aug 24, 2017 · 5 comments
Closed

Rename Options to Something Else? #12

ghost opened this issue Aug 24, 2017 · 5 comments
Assignees

Comments

@ghost
Copy link

ghost commented Aug 24, 2017

There has been some discussion on renaming the options parameter here: https://github.com/desiringgod/components-rails/blob/master/lib/components/rails/component.rb#L22 to something else.

@scottcorgan and anyone else, feel free to link other conversations related to that here.

A couple of potential options are attributes or properties.

I personally like attributes, because this is still Ruby, and attributes is a commonly used Ruby/Rails word, but lacks the drawbacks of the word options.

If you want to weigh in with conversation, feel free to do so. If you want to weigh in with a single word that's your vote, feel free to do that, and possibly we can form some consensus and close out this Issue quickly.

@shanebo
Copy link

shanebo commented Aug 24, 2017

Vote on: attributes

@shanebo
Copy link

shanebo commented Aug 24, 2017

Vote on: properties

@shanebo
Copy link

shanebo commented Aug 24, 2017

Vote on:
attributes for required
options for optional attributes

@scottcorgan
Copy link

I think they'll all just be considered in one name, but the goal is to throw an error for any we forgot

@scottcorgan
Copy link

@shanebo @hchasey note that there are class properties that we set to indicate if they're required or optional. And if they're optional, we give a default value.

See #10 (comment)

@shanebo shanebo removed their assignment Aug 25, 2017
@ghost ghost closed this as completed in #16 Sep 1, 2017
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants