You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I use a commit hook that does git grep -P, i.e. uses Perl regexps which is a compile time dependency. This works everywhere but Atom's git support, where it fails because that git is built without it.
It seems that just about everyone else compiles with pcre. Short list of git versions we use where this works:
Linux and Homebrew distributions
Github Desktop on Mac and Windows
Recent Apple versions (Apple Git-98). The system (xcode) git used to not have PCRE a while back (when it was an ancient 1.8.something) but it does as of High Sierra.
Official git-scm.org package for Mac
Having an embedded git, while convenient, should follow mainstream git as closely as possible in my opinion. And PCRE in turn is probably the "mainstream RE" these days and not some esoteric option.
I've taken to telling people who use Atom to simply remove the dugite git-core, forcing it to use system, but this seems sub-optimal if you guys are relying on the behaviors of a fixed version. Eliminating the grep -P is non-trivial.
@ovy I realise I never asked which OS you were running on. I'm putting together a build in #105 and it seems fairly easy to add support for Linux AMD64 and macOS, just wanted to confirm those will cover your use case.
@shiftkey: thanks much for addressing this! The OS'es we use are primarily macOS and Linux (AMD64 indeed), with Windows a distant third use case that won't be missed as badly if the PCRE compile is more involved.
I use a commit hook that does
git grep -P
, i.e. uses Perl regexps which is a compile time dependency. This works everywhere but Atom's git support, where it fails because that git is built without it.It seems that just about everyone else compiles with pcre. Short list of git versions we use where this works:
Having an embedded git, while convenient, should follow mainstream git as closely as possible in my opinion. And PCRE in turn is probably the "mainstream RE" these days and not some esoteric option.
I've taken to telling people who use Atom to simply remove the dugite git-core, forcing it to use system, but this seems sub-optimal if you guys are relying on the behaviors of a fixed version. Eliminating the
grep -P
is non-trivial.[Re-filed here from https://github.com/desktop/dugite/issues/160 as requested by @shiftkey ]
The text was updated successfully, but these errors were encountered: