Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prop types #46

Merged
merged 4 commits into from
Jul 8, 2019
Merged

Add prop types #46

merged 4 commits into from
Jul 8, 2019

Conversation

japamat0
Copy link
Contributor

Issue [#41]

I added prop types and default props to the following components:

App.js
Burst.js
ErrorToast.js
Frame.js
Preview.js
Settings.js
Sidebar.js
SidebarButton.js
SidebarButtonWithBadge.js

Default props for connected components have been set to match initial state from the store, with there mapDispatchToProps functions have been set as simple arrow functions, i.e. () => {}. For non connected components, the default props have been set to match the properties applied where those components are rendered, i.e. where <Frame /> is rendered within <Preview />

@mmmaaatttttt & @alissarenz please review before @ctlusto

  • thanks!

@ctlusto ctlusto merged commit fd29637 into desmosinc:master Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants