Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue7 #16

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Issue7 #16

merged 3 commits into from
Oct 7, 2024

Conversation

Sofiyan-coder
Copy link
Contributor

Fixes #7

Description

Change the type from Integer to Long on line 28 of the Product class.


This change will cause the application to no longer compile with maven, because you have to update all classes related to the Product entity ID field.

List of Classes needed to Modified

image

Finally, in the SQL script schema.sql change the type to BIGINT on line 20 and line 97.

Copy link
Contributor

deepsource-io bot commented Oct 1, 2024

Here's the code health analysis summary for commits 3ef4905..f7044bf. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Java LogoJava✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@nmarulo nmarulo self-assigned this Oct 1, 2024
@nmarulo
Copy link
Member

nmarulo commented Oct 1, 2024

@Sofiyan-coder Please check the compilation process, because it has failed.

The problem may be ShoppingListController.java.

https://github.com/despensa-app/despensa-rest-api/actions/runs/11132954558/job/30939121344

@Sofiyan-coder
Copy link
Contributor Author

ok I will take a look at it and Update you

@Sofiyan-coder
Copy link
Contributor Author

@nmarulo I tried one last time. Please check now to see if the error occurs again. I can understand your actions regarding this issue #7

Thank you

@Sofiyan-coder
Copy link
Contributor Author

@nmarulo is it working now?

@nmarulo
Copy link
Member

nmarulo commented Oct 7, 2024

@Sofiyan-coder Thanks

@nmarulo nmarulo added the hacktoberfest-accepted PR aceptadas para el hacktoberfest label Oct 7, 2024
@nmarulo nmarulo merged commit a9449a9 into despensa-app:master Oct 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted PR aceptadas para el hacktoberfest Size: S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update type in Product database
2 participants