chat-gui-112: Enhance message user info window #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11k
requested changes
Apr 18, 2023
| @@ -49,6 +49,10 @@ export default class ChatUserInfoMenu extends ChatMenuFloating { | |||
| this.chat.output.on('mouseup', '.msg-user .user', (e) => { | |||
| e.stopPropagation(); | |||
| }); | |||
|
|
|||
| this.chat.output.on('DOMSubtreeModified', (e) => { | |||
There was a problem hiding this comment.
DOMSubtreeModified seems to be part of the MutationEvent family of APIs, which is deprecated according to MDN's docs. I think you should use MutationObserver instead.
Also, there's a bug where, if you have a DM window for the target open, you can see messages from both the DM window and the main chat window. You should monitor changes in the currently-visible window only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue 112: #112
When users right click on a username from the chat window, we now parse out all messages that are authored by selected username and display as a message history in the user info menu. As long as the user info menu remains open, an event listener will dynamically update the message history based on the chat ui. Older messages will disappear from the selected user message history as they disappear from chat and new messages will render as they're added to the chat.
Untitled.mp4