Add feature of drawing borders on unfocused windows too #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add function to query a window map state using xwininfo command
given an X window id
- There is a caching mechanism for querying window map state and
storing it in viewable_window_map. Every half a second it will be
updated for every window and to prevent this map to grow
uncontrolled (when closing windows we don't want those items in our
map) we need to cleanup somehow, the current logic is to throw the
whole map and recreate it on demand.
|
This is old, since we don't use subprocesses for window data anymore |
|
Can we reopen this @deter0? I didn't find a python library to get the Viewable property of open windows, that was the reason to use subprocess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aim is to resolve #16
given an X window id
storing it in viewable_window_map. Every half a second it will be
updated for every window and to prevent this map to grow
uncontrolled (when closing windows we don't want those items in our
map) we need to cleanup somehow, the current logic is to throw the
whole map and recreate it on demand.