Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor components for easier testing #2

Open
bnchdrff opened this issue Sep 23, 2017 · 0 comments
Open

refactor components for easier testing #2

bnchdrff opened this issue Sep 23, 2017 · 0 comments

Comments

@bnchdrff
Copy link
Member

we can use the container/component system, where a container makes all the bindings to state management (redux/react router) and then passes in clear, easily mockable functions to functional components.

i got lazy w/ many of the components and they are messy, currently.

see https://medium.com/@dan_abramov/smart-and-dumb-components-7ca2f9a7c7d0 and https://reacttraining.com/react-router/web/guides/testing for react-router specific stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant