Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miniature Navigation bar does not close after clicking a link #5

Open
sigonasr2 opened this issue May 1, 2019 · 4 comments
Open

Miniature Navigation bar does not close after clicking a link #5

sigonasr2 opened this issue May 1, 2019 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@sigonasr2
Copy link

The miniature pull-down navigation bar does not close once a link has been clicked. This means the user has to close it manually after selecting an option.

The small and larger versions of the navigation bar do not have this issue as they do not close/open.
@kevinfalting
Copy link
Member

This probably require some js that is listing for an onclick of each of the links that closes it.

@sigonasr2 sigonasr2 mentioned this issue May 7, 2019
Merged
sigonasr2 referenced this issue in sigonasr2/dev-osan.github.io May 7, 2019
@sigonasr2
Add in shadowing to make devOsan title stand out and readable. Made l…
a17ed33 
…inks stand out more with bolding and underlining. Created script to collapse menu. This is a fix for Issue #5
This was referenced May 7, 2019
Merged
Closed
@matthewjamesr
Copy link
Member

Reference this Vuejs code (func mobileMenu) as example to toggle the nav.

https://matthewjamesr.gitlab.io/voodoo-vcp/

https://matthewjamesr.gitlab.io/voodoo-vcp/js/index.js

@sigonasr2
Copy link
Author

Pull Request #18 resolves this issue.

kevinfalting pushed a commit that referenced this issue May 28, 2019
@sigonasr2
Add in shadowing to make devOsan title stand out and readable. Made l…
c4f30b9 
…inks stand out more with bolding and underlining. Created script to collapse menu. This is a fix for Issue #5
kevinfalting pushed a commit that referenced this issue May 28, 2019
@sigonasr2
Created script to collapse menu. This is a fix for Issue #5
3ba2ba6
kevinfalting added a commit that referenced this issue May 28, 2019
@kevinfalting
Merge pull request #18 from sigonasr2/collapsibleMenu-branch
8f2eb87 
Created script to collapse menu. This is a fix for Issue #5

This looks great, the only thing I found was the logo that links to the top of the page isn't closing the drawer. We'll open a separate issue for it though. Thanks for the hard work!
@kevinfalting
Copy link
Member

The logo that links to the top of the page isn't closing the drawer, follow the same logic as the rest of the nav links.

@kevinfalting kevinfalting added enhancement New feature or request good first issue Good for newcomers labels May 28, 2019
kevinfalting pushed a commit that referenced this issue May 28, 2019
@sigonasr2
Merge pull request #10 from sigonasr2/collapsibleMenu-branch
b2b09f0 
Created script to collapse menu. This is a fix for Issue #5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@matthewjamesr @sigonasr2 @kevinfalting