Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The rebornix.Ruby extension is marked as deprecated #870

Closed
jcansdale opened this issue Dec 5, 2023 · 3 comments
Closed

The rebornix.Ruby extension is marked as deprecated #870

jcansdale opened this issue Dec 5, 2023 · 3 comments

Comments

@jcansdale
Copy link

The rebornix.Ruby extension is marked as deprecated. It suggests moving to the shopify.ruby-lsp extension instead.

Image

Should we update the devcontainer.json here?
https://github.com/devcontainers/images/blob/main/src/ruby/.devcontainer/devcontainer.json#L27

@eljog
Copy link
Member

eljog commented Dec 6, 2023

Thank you for bringing this up, we really appreciate it. If you have time would you mind contributing a PR?

@eljog
Copy link
Member

eljog commented Dec 9, 2023

Apparently we already have a PR out for this #860
We have been waiting to learn more about the preferences of the community
https://github.com/devcontainers/images/pull/860/files#r1406569477

it's certainly a trickly problem to tackle as everyone has their own set of preferences. Since I'm not sure we've seen other requests to add this extension pack, my first instinct is we leave this PR open for further community feedback.

@eljog
Copy link
Member

eljog commented Dec 20, 2023

#894 has removed the deprecated extension for devcontainer, and the ruby feature here is already installing the suggested shopify.ruby-lsp extension.
🎉

@eljog eljog closed this as completed Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants