Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NotFoundError is not raised, but Python FileNotFoundError is raised #197

Open
ion-elgreco opened this issue Feb 3, 2025 · 1 comment · May be fixed by #199
Open

NotFoundError is not raised, but Python FileNotFoundError is raised #197

ion-elgreco opened this issue Feb 3, 2025 · 1 comment · May be fixed by #199

Comments

@ion-elgreco
Copy link

ion-elgreco commented Feb 3, 2025 •
edited
Loading

Noticed this while making an integration in dagster (dagster-io/dagster#27450), is that NotFoundError is not raised when you try to do obs.head(), you actually get the standard FileNotFoundError exception. Not sure if this was intended? But it threw me off for a second, since I imported the notFoundError from the execptions module : )
@kylebarron
Copy link
Member

We can standardize on the obstore exception. Would you like to submit a PR?

@kylebarron kylebarron linked a pull request Feb 3, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Standardize on obstore's NotFoundError developmentseed/obstore
2 participants
@kylebarron @ion-elgreco