-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to CSS-in-JS #145
Comments
i'd suggest |
I'm voting for deeper research before choosing a particular solution because all the solutions have a different impact on the runtime. Especially if we want the approach that will work with CRA without additional configuration. The most important question now is how in hurry are we with this decision?
I'd like to notice here that almost every css-in-js tool that I met has very similar syntax/api and similar rules of working (overriding, scoping, etc.). I think the experience our team gained could be applied to any other solution, not only |
Do we have time for such deeper research? Right now I have some spare time to migrate everything - I'd like to use such opportunity. Besides you're pointing the API accross the libs is similary so we could possibly replace SC with something more performant later, right? |
I am voting for SC because of bigger community, better tools and integration etc. Anyway API is very similar |
I think if we decide to get deeper research, we lost an excellent opportunity for migration. So I am voting for start migration to SC. If we reach some restrictions, it should be easy to migrate to another library. @raveclassic if you decided to do this task, please keep in mind 3 level of styles that we spoke a lot.
|
We had a chat with @mankdev about SC and decided to wait for an upcoming release of Design System from our design team. Therefore I'm putting this issue on hold. Anyway I'm going to send another PR with update of react and storybook |
This is going to track an upcoming migration to a css-in-js solution. Which one is to be decided but I suggest
styled-components
because one of our teams has experience of using it in a production-running project.Any thoughts?
/cc @sutarmin @igoralekseev @mankdev @dramoturg
UPD:
lower-dash-case
in file names across all packages #84The text was updated successfully, but these errors were encountered: