Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the namespace value under helm chart metadata #1432

Closed
7 tasks done
Tracked by #1274
michael-valdron opened this issue Feb 1, 2024 · 4 comments · Fixed by devfile/registry-support#230
Closed
7 tasks done
Tracked by #1274

Set the namespace value under helm chart metadata #1432

michael-valdron opened this issue Feb 1, 2024 · 4 comments · Fixed by devfile/registry-support#230
Assignees
Labels
area/registry Devfile registry for stacks and infrastructure

Comments

@michael-valdron
Copy link
Member

michael-valdron commented Feb 1, 2024

Which area/kind this issue is related to?

/area registry

Issue Description

The helm chart should set the namespace deployed to under the metadata.namespace field as the registry operator does: https://github.com/devfile/registry-operator/blob/f55ab8e7c8061934547c7d55bd67d81d509a8752/pkg/registry/configmap.go#L62

Parent Epic: #1274

Acceptance Criteria

@openshift-ci openshift-ci bot added the area/registry Devfile registry for stacks and infrastructure label Feb 1, 2024
@michael-valdron michael-valdron self-assigned this Feb 20, 2024
@michael-valdron michael-valdron moved this to Refinement in Devfile Project Feb 20, 2024
@thepetk thepetk moved this from Refinement to Backlog in Devfile Project Feb 21, 2024
@michael-valdron michael-valdron moved this from Backlog to To Do 📝 in Devfile Project Mar 12, 2024
@michael-valdron michael-valdron moved this from To Do 📝 to In Progress 🚧 in Devfile Project Mar 27, 2024
@michael-valdron
Copy link
Member Author

Set metadata.namespace in all helm chart template specs, verifying changes under OpenShift 4.13 and Kubernetes 1.26 (minikube)

@michael-valdron
Copy link
Member Author

Deployment is success under minikube and metadata.namespace appears to be set correctly under deployed specs (deployed under default namespace in this case):

Image

@michael-valdron
Copy link
Member Author

Deployment also is success under OpenShift 4.13 and metadata.namespace appears to be set correctly under deployed specs (deployed under default namespace in this case):

Image

@michael-valdron
Copy link
Member Author

PR devfile/registry-support#230 is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/registry Devfile registry for stacks and infrastructure
Projects
Status: Done ✅
Development

Successfully merging a pull request may close this issue.

1 participant