Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry operator CI check format task is failing #1643

Closed
thepetk opened this issue Oct 3, 2024 · 1 comment · Fixed by devfile/registry-operator#101
Closed

Registry operator CI check format task is failing #1643

thepetk opened this issue Oct 3, 2024 · 1 comment · Fixed by devfile/registry-operator#101
Assignees
Labels
area/registry Devfile registry for stacks and infrastructure kind/bug Something isn't working severity/blocker Issues that prevent developers from working

Comments

@thepetk
Copy link
Contributor

thepetk commented Oct 3, 2024

/kind bug

Which area is this bug related to?

/area registry

Bug Summary

Describe the bug:

The CI check format task is currently failing due to an issue that goimports module has. The output of the error is:

Run go get -u github.com/google/addlicense@dc31ac9ffcca99c9457226366135701794b128c0
go: downloading github.com/google/addlicense v1.1.1
go: downloading github.com/bmatcuk/doublestar/v4 v4.0.2
go: downloading golang.org/x/sync v0.8.0
go: downloading github.com/bmatcuk/doublestar/v4 v4.6.1
go: downloading github.com/bmatcuk/doublestar v1.3.4
go: added github.com/bmatcuk/doublestar/v4 v4.6.1
go: added github.com/google/addlicense v1.1.1
go: upgraded golang.org/x/sync v0.6.0 => v0.8.0
go: downloading golang.org/x/sync v0.0.0-20190911185100-cd5d95a43a6e
go: downloading golang.org/x/tools v0.[22](https://github.com/devfile/registry-operator/actions/runs/10959109328/job/30958870849?pr=100#step:7:23).1-0.20240701152122-0cc407e63f5f
go: downloading golang.org/x/mod v0.18.0
go: downloading golang.org/x/mod v0.21.0
go: golang.org/x/[email protected] requires go >= 1.22.0 (running go 1.21.13)
go: golang.org/x/[email protected] requires go >= 1.22.0 (running go 1.21.13)
go: golang.org/x/[email protected] requires go >= 1.22.0 (running go 1.21.13)
go: golang.org/x/[email protected] requires go >= 1.22.0 (running go 1.21.13)
go: golang.org/x/[email protected] requires go >= 1.22.0 (running go 1.21.13)
go: golang.org/x/[email protected] requires go >= 1.22.0 (running go 1.21.13)

To Reproduce:

You can see an example here: https://github.com/devfile/registry-operator/actions/runs/10959109328/job/30958870849?pr=100

Expected behavior

The goimports should be ok without dependency issues.

Any logs, error output, screenshots etc? Provide the devfile that sees this bug, if applicable

Shared above.

Additional context

This issue is currently blocking the PR's CI.

Any workaround?

We could either investigate a workaround of using a different goimports version or removing temporarily the -u flag.

@openshift-ci openshift-ci bot added kind/bug Something isn't working area/registry Devfile registry for stacks and infrastructure labels Oct 3, 2024
@Jdubrick Jdubrick moved this to Refinement in Devfile Project Oct 3, 2024
@thepetk thepetk added the severity/blocker Issues that prevent developers from working label Oct 5, 2024
@thepetk
Copy link
Contributor Author

thepetk commented Oct 5, 2024

currently blocks: devfile/registry-operator#100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/registry Devfile registry for stacks and infrastructure kind/bug Something isn't working severity/blocker Issues that prevent developers from working
Projects
Status: Done ✅
Development

Successfully merging a pull request may close this issue.

2 participants