fix: fix fast relative volume updates #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relative volume changes would use old values, not the new value set by a volume change in the last second. To fix this, update the player state immediately and only delay sending the update (instead of also delaying the update to the player state). This could mean that another change (such as play/pause) would send an earlier volume update, but I don't think that's a problem. We'll send a PutStateReason_VOLUME_CHANGED anyway after a second.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relative volume changes would use old values, not the new value set by a volume change in the last second. To fix this, update the player state immediately and only delay sending the update (instead of also delaying the update to the player state).
This could mean that another change (such as play/pause) would send an earlier volume update, but I don't think that's a problem. We'll send a PutStateReason_VOLUME_CHANGED anyway after a second.
Fixes #141
This is an alternative to #142