Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some log messages are no longer seen when using rpc.dll #320

Open
msbreton opened this issue Aug 13, 2024 · 2 comments
Open

Some log messages are no longer seen when using rpc.dll #320

msbreton opened this issue Aug 13, 2024 · 2 comments

Comments

@msbreton
Copy link

Describe the bug 🪲
In rpc.dll 2.19.0, some log messages were displayed to stdout. In rpc.dll 2.23.0, this changed to stderr.
This makes seeing/capturing critical messages, especially when debugging an issue. almost impossible.

At a minimum, we request, you revert log message output to stdout but that still makes it difficult for calling applications to capture that output.
Our preference would be that you return ALL log messages to ref _output, so the calling application can include those messages in its log output.

To Reproduce 🪜
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots 🖼️
If applicable, add screenshots to help explain your problem.

AMT Device (please complete the following information): 🖥️

  • OS: [e.g. Linux Kernel & Version]
  • AMT Version: [e.g. 11.8.5, 12.0.45]
  • AMT Configuration Mode: [e.g. Admin Control Mode or Client Control Mode]
  • Network Configuration [e.g. Dynamic IP or Static IP]

Service Deployment (please complete the following information): ⛈️

  • Deployment Type: [e.g. Azure, Docker, K8s]
  • Node Version: [e.g. LTS 14]
  • Component & Version: [e.g. RPS 2.0.0]

Additional context
Add any other context about the problem here.

@graikhel-intel
Copy link
Contributor

Hello @msbreton, the PR device-management-toolkit/rpc-go#640 has been merged and available in the latest release. Does this resolve the issue?

@msbreton
Copy link
Author

Not entirely. The fix in device-management-toolkit/rpc-go#640 did result in the log messages showing up in stdout again but that's really only useful when testing the library in a console app. When calling it from another application, those log messages are lost. It would be preferable if they were returned via ref _output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants