Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly build fails due native image building GUI #392

Closed
hohwille opened this issue Jun 14, 2024 · 2 comments
Closed

Nightly build fails due native image building GUI #392

hohwille opened this issue Jun 14, 2024 · 2 comments
Labels
bug Something isn't working SCM software-configuration-management (github actions, internal processes, git or github utilization)
Milestone

Comments

@hohwille
Copy link
Member

Expected behavior

Build should work.

Actual behavior

Build fails:

Error:  Failed to execute goal on project gui: Could not resolve dependencies for project com.devonfw.tools.IDEasy:gui:jar:2024.06.001-alpha-SNAPSHOT: The following artifacts could not be resolved: org.openjfx:javafx-controls:jar:${javafx.platform}:21 (absent), org.openjfx:javafx-graphics:jar:${javafx.platform}:21 (absent), org.openjfx:javafx-base:jar:${javafx.platform}:21 (absent), org.openjfx:javafx-fxml:jar:${javafx.platform}:21 (absent): Could not find artifact org.openjfx:javafx-controls:jar:${javafx.platform}:21 in central (https://repo.maven.apache.org/maven2) -> [Help 1]

Steps to reproduce (bug) / Use Case of feature request (enhancement)

  1. build GUI on macos with latest stable maven

Related/Dependent Issues

#349

Comments/Hints:

https://stackoverflow.com/questions/78542808/maven-project-fails-to-resolve-javafx-dependencies

@hohwille hohwille added the bug Something isn't working label Jun 14, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in IDEasy board Jun 14, 2024
@slskiba
Copy link
Contributor

slskiba commented Jun 14, 2024

Unfortunately this is a problem with maven version 3.9.7, in which the javafx.platform property not being replaced correctly. Setting this property manually when building (i.e. -Djavafx.platform=win, or -Djavafx.platform=mac respectively) fixes this issue. See also: https://issues.apache.org/jira/browse/MNG-8131

I can confirm that also locally the build fails on windows and macos for the same reason. I have tested building with 3.9.6, which works just fine. This is also the version set in dev-ide-settings.

hohwille added a commit to ndemirca/IDEasy that referenced this issue Jun 17, 2024
@hohwille
Copy link
Member Author

Seems I solved this problem within my added changes of #372.
As CI is not affected we seem to already use maven <= 3.9.6 in our regular builds but only during the graalVM setup action we have been getting the error. Since it is waste to build all modules in the matrix.os builds that just produce the native-images, I changed to only build the cli so I will now close this issue.

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in IDEasy board Jun 17, 2024
@hohwille hohwille added this to the internal milestone Sep 13, 2024
@hohwille hohwille added the SCM software-configuration-management (github actions, internal processes, git or github utilization) label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working SCM software-configuration-management (github actions, internal processes, git or github utilization)
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants