Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-completion of version still buggy #418

Closed
hohwille opened this issue Jun 25, 2024 · 0 comments · Fixed by #432
Closed

auto-completion of version still buggy #418

hohwille opened this issue Jun 25, 2024 · 0 comments · Fixed by #432
Assignees
Labels
bug Something isn't working

Comments

@hohwille
Copy link
Member

Expected behavior

As a IDEasy user, I want to use auto-completion so that I can type faster and avoid typos.
Therefore I expect to get all matching versions of a tool properly suggested e.g. when completing ide install aws 2.1.

Actual behavior

$ ide complete install aws 2.
2.17.1
2.*
...
$ ide complete install aws 2.1
2.1.39
2.1*
2.1.38
2.1.37
2.1.36
2.1.35
2.1.34
2.1.33
2.1.32
2.1.31
2.1.30
2.1.29
2.1.28
2.1.27
2.1.26
2.1.25
2.1.24
2.1.23
2.1.22
2.1.21
2.1.20
2.1.19
2.1.18
2.1.17
2.1.16
2.1.15
2.1.14
2.1.13
2.1.12
2.1.11
2.1.10
2.1.9
2.1.8
2.1.7
2.1.6
2.1.5
2.1.4
2.1.3
2.1.2
2.1.1
2.1.0
2.1*!

As we can see completing 2.1 only suggests versions that match 2.1* (starting with 2.1.) but this is not what the user wants.
Instead it should also match versions such as 2.17.1 or 2.16.12 just to give a few missing examples.

Steps to reproduce (bug) / Use Case of feature request (enhancement)

  1. see above, you can also run ide shell and use embedded auto-completion.

Related/Dependent Issues

Comments/Hints:

I have the feeling that this is related to the semantic sorting of versions (2.17.0, 2.16.0, ..., 2.1.0, 2.1.1) and the binary search in combination with the lexicographic matching (and startsWith) in completion (2.1 should match 2.17 and 2.16 but those are in the sorted list before 2.1 so only the versions from 2.1 in the sort order are considered)

Affected version:

  • current version (2024.06.002-alpha-SNAPSHOT)
@hohwille hohwille added the bug Something isn't working label Jun 25, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in IDEasy board Jun 25, 2024
@slskiba slskiba self-assigned this Jun 28, 2024
@slskiba slskiba moved this from 🆕 New to 📋 Backlog in IDEasy board Jun 28, 2024
@slskiba slskiba moved this from 📋 Backlog to 🏗 In progress in IDEasy board Jul 1, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in IDEasy board Jul 1, 2024
@hohwille hohwille added this to the release:2024.06.002 milestone Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants