Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FileUtil.makeExecutable(Path) #542

Closed
hohwille opened this issue Aug 19, 2024 · 0 comments · Fixed by #586
Closed

Add FileUtil.makeExecutable(Path) #542

hohwille opened this issue Aug 19, 2024 · 0 comments · Fixed by #586
Assignees
@jan-vcapgemini
Labels
enhancement New feature or request
Milestone
release:2024.09.001

Comments

@hohwille
Copy link
Member

hohwille commented Aug 19, 2024 •
edited by jan-vcapgemini
Loading

In several PRs we have already discussed about making a file executable (see resolved review comments):

To avoid copy&paste and other hacks, we should create a clean solution:

  • Add new method makeExecutable(Path) to FileAccess
  • Implement that in FileAccessImpl so that it behaves like chmod a+x on the given file.
  • If the given Path does not exist, the method should fail.
  • On Windows it should behave like chmod a+x «file» in git-bash (do nothing) but on all other OS it should add the executable flags (without modifying other file attributes).
@hohwille hohwille added the enhancement New feature or request label Aug 19, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in IDEasy board Aug 19, 2024
@hohwille hohwille mentioned this issue Aug 19, 2024
Merged
@jan-vcapgemini jan-vcapgemini self-assigned this Aug 27, 2024
@jan-vcapgemini jan-vcapgemini moved this from 🆕 New to 🏗 In progress in IDEasy board Aug 27, 2024
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Aug 27, 2024
@jan-vcapgemini
devonfw#542, devonfw#505: added makeExecutable to FileAccess
e4b0c61 
removed setMacOsFilePermissions method from Intellij
used makeExecutable from FileAccess instead
@hohwille hohwille added this to the release:2024.09.001 milestone Sep 3, 2024
@hohwille hohwille linked a pull request Sep 3, 2024 that will close this issue
#505: create startup script command #540
Merged
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Sep 5, 2024
@jan-vcapgemini
devonfw#542: added makeExecutable
c7f8706 
replaced default implementation of makeExecutable with an equivalent of 'chmod a+x'.
made sure that no permission changes will be applied on Windows
@jan-vcapgemini jan-vcapgemini mentioned this issue Sep 5, 2024
Merged
hohwille pushed a commit that referenced this issue Sep 5, 2024
@jan-vcapgemini
#542: added makeExecutable (#586)
abdd35a
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in IDEasy board Sep 5, 2024
@hohwille hohwille removed a link to a pull request Sep 12, 2024
#505: create startup script command #540
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jan-vcapgemini jan-vcapgemini

Labels
enhancement New feature or request
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2024.09.001
Development

Successfully merging a pull request may close this issue.

#542: added makeExecutable jan-vcapgemini/IDEasy
2 participants
@hohwille @jan-vcapgemini