Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify multi-keyword commandlets and make usage consistent #79

Closed
hohwille opened this issue Oct 10, 2023 · 0 comments · Fixed by #92
Closed

Simplify multi-keyword commandlets and make usage consistent #79

hohwille opened this issue Oct 10, 2023 · 0 comments · Fixed by #92
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@hohwille
Copy link
Member

hohwille commented Oct 10, 2023

From #5:

Currently ide set mvn version 3.9.3 sets the maven version to 3.9.3.
Each commandlet must have a unique name that should also give an idea what the commandlet is about.
Currently I named this commandlet set-version what seems to make sense.
Also this would allow later to also have a ide set intellij edition ultimate that would be handled by a set-edition commandlet.
As a result you would need to type ide help set-version to get the help of set-version commandlet and ide help set-edition to get the help of set-edition commandlet. Would it then be better to also change the command syntax to ide set-version mvn 3.9.3 and ide set-edition intellij ultimate? IMHO this would avoid some user-confusion.

As I did not get any feedback, I now decide that we should go for this approach as it will make our life easier and the help and usage more consistent. A little drawback is that ide set mvn version 3.9.3 is a little bit more natural language than ide set-version mvn 3.9.3. However, if we later think this is relevant, we can still add some CLI alias syntax concept that allows to have ide set mvn version 3.9.3 as a kind of alias to ide set-version mvn 3.9.3 what would still be the primary syntax.
FYI: Feel free to also change VersionSetCommandlet to SetVersionCommandlet, etc. if that makes more sense for you then.

@hohwille hohwille added the enhancement New feature or request label Oct 10, 2023
@hohwille hohwille added this to the release:2024.01.001 milestone Oct 10, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in IDEasy board Oct 10, 2023
@hohwille hohwille added the good first issue Good for newcomers label Oct 10, 2023
@aBega2000 aBega2000 self-assigned this Oct 13, 2023
@aBega2000 aBega2000 moved this from 🆕 New to 🏗 In progress in IDEasy board Oct 13, 2023
aBega2000 added a commit to aBega2000/IDEasy that referenced this issue Oct 16, 2023
aBega2000 added a commit to aBega2000/IDEasy that referenced this issue Oct 16, 2023
aBega2000 added a commit to aBega2000/IDEasy that referenced this issue Oct 16, 2023
aBega2000 added a commit to aBega2000/IDEasy that referenced this issue Oct 16, 2023
@hohwille hohwille linked a pull request Oct 17, 2023 that will close this issue
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in IDEasy board Oct 17, 2023
hohwille pushed a commit to hohwille/IDEasy that referenced this issue Oct 24, 2023
hohwille pushed a commit to hohwille/IDEasy that referenced this issue Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants