#898: Improved output of get-version/edition and uninstall/-plugin #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 19, 2024 12:57
Edition/VersionGetCommandlet changed them to log the configured option if the tool is not installed and the installed option if it is installed. Changed the toolInstallInfo method to log into IdeSublogger instead of using context.info or context.warning. Changed the uninstall commandlet to log a warning in case the requested commandlet is not installed. Changed the uninstallPlugin commandlet to give feedback wether the plugin could be deleted or if there was not installation found. Adjusted Tests for Edition/VersionGetCommandlet as well as Uninstall commandlet to expect the correct loglevel or content of logged messages. Added logAtProccessable to IdeTestContextAssertions to check if a log-message was logged on PROCESSABLE-level. Added .ide.software.version file to the npm software in the basic ide-test-project-ressource, since it was needed to test my implementation.
added CHANGELOG entry
Pull Request Test Coverage Report for Build 12435451937Details
💛 - Coveralls |
hohwille
reviewed
Dec 20, 2024
cli/src/main/java/com/devonfw/tools/ide/commandlet/VersionGetCommandlet.java
Outdated
Show resolved
Hide resolved
|
@jan-vcapgemini please have a look. |
So if I get this correct, the test was expecting the message |
hohwille
changed the title
hohwille
requested changes
Jan 7, 2025
Comment on lines
+134
to
+136
| * @return 0 if the uninstallation was successfull and 1 if it failed | ||
| */ | ||
| public void uninstallPlugin(ToolPluginDescriptor plugin) { | ||
| public int uninstallPlugin(ToolPluginDescriptor plugin) { |
There was a problem hiding this comment.
boolean success flag instead of int?
Or throw an exception in case of failure/error?
Or do the logging in this method and keep void return type?
IMHO the last option makes to most sense.
Comment on lines
+90
to
+93
| assertThat(context).log().hasEntries(IdeLogEntry.ofProcessable("No installation of tool java was found."), | ||
| IdeLogEntry.ofProcessable("The configured edition for tool java is java"), | ||
| IdeLogEntry.ofProcessable("To install that edition call the following command:"), | ||
| IdeLogEntry.ofProcessable("ide install java")); |
There was a problem hiding this comment.
See my comment about the failing test...
Suggested change
| assertThat(context).log().hasEntries(IdeLogEntry.ofProcessable("No installation of tool java was found."), | |
| IdeLogEntry.ofProcessable("The configured edition for tool java is java"), | |
| IdeLogEntry.ofProcessable("To install that edition call the following command:"), | |
| IdeLogEntry.ofProcessable("ide install java")); | |
| assertThat(context).log().hasEntries(IdeLogEntry.ofProcessable("java")); |
| IdeLogEntry.ofInfo("The configured edition for tool az is az"), | ||
| IdeLogEntry.ofInfo("To install that edition call the following command:"), | ||
| IdeLogEntry.ofInfo("ide install az")); | ||
| assertThat(context).logAtProcessable().hasMessage("az"); |
There was a problem hiding this comment.
here it seems vice versa. The output in the test was like this:
14:20:56.527 [main] - INFO - c.d.tools.ide.log.IdeSubLoggerSlf4j - PROCESSABLE:No installation of tool az was found.
14:20:56.527 [main] - INFO - c.d.tools.ide.log.IdeSubLoggerSlf4j - PROCESSABLE:The configured edition for tool az is az
14:20:56.527 [main] - INFO - c.d.tools.ide.log.IdeSubLoggerSlf4j - PROCESSABLE:To install that edition call the following command:
14:20:56.527 [main] - INFO - c.d.tools.ide.log.IdeSubLoggerSlf4j - PROCESSABLE:ide install az
So IMHO something is still broken with the implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #898
Edition/VersionGetCommandlet changed them to log the configured option if the tool is not installed and the installed option if it is installed.
Changed the toolInstallInfo method to log into IdeSublogger instead of using context.info or context.warning.
Changed the uninstall commandlet to log a warning in case the requested commandlet is not installed.
Changed the uninstallPlugin commandlet to give feedback wether the plugin could be deleted or if there was not installation found.
Adjusted Tests for Edition/VersionGetCommandlet as well as Uninstall commandlet to expect the correct loglevel or content of logged messages.
Added logAtProccessable to IdeTestContextAssertions to check if a log-message was logged on PROCESSABLE-level.
Added .ide.software.version file to the npm software in the basic ide-test-project-ressource, since it was needed to test my implementation.