Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

continually writing data to disk and syncing packets from the tick loop #16

Open
sleepy-evelyn opened this issue Apr 27, 2021 · 0 comments
Labels
enhancement New feature or request Oh dear

Comments

@sleepy-evelyn
Copy link
Contributor

sleepy-evelyn commented Apr 27, 2021

An example here: https://github.com/Archydra-Studios/Through-the-Looking-Glass/blob/master/src/main/java/azzy/fabric/lookingglass/blockentity/GrinderEntity.java#L53

markDirty() in the tick loop. Could be ok if it was marking say an animation for the machine when it starts processing stuff but it seems to be marking the data to be written to disk all the time. Potential to create excess lag.
sync() spamming packets to the client, same reason as markDirty really, potential to cause lag on the server and delay other packets from being sent in time

@sleepy-evelyn sleepy-evelyn changed the title Read/write from disk during the tick loop continually writing data to disk and syncing packets from the tick loop Apr 27, 2021
@Azzyypaaras Azzyypaaras added enhancement New feature or request Oh dear labels Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Oh dear
Projects
None yet
Development

No branches or pull requests

2 participants