refactor: remove unused imports & ? checks

devtron-labs · Feb 27, 2024 · f330de6 · f330de6
1 parent bc4e2c4
commit f330de6
Show file tree

Hide file tree

Showing 9 changed files with 14 additions and 28 deletions.
diff --git a/src/components/ApplicationGroup/Details/TriggerView/EnvTriggerView.tsx b/src/components/ApplicationGroup/Details/TriggerView/EnvTriggerView.tsx
@@ -216,9 +216,7 @@ export default function EnvTriggerView({ filteredAppIds, isVirtualEnv }: AppGrou
             setDefaultConfig(_isDefaultConfig)
             setConfigPresent(isConfigPresent)
         })
-        .catch((error) => {
-          showError(error)
-        })
+        .catch()
     }
 
     const preserveSelection = (_workflows: WorkflowType[]) => {

diff --git a/src/components/EnvironmentOverride/DeploymentTemplateOverrideForm.tsx b/src/components/EnvironmentOverride/DeploymentTemplateOverrideForm.tsx
@@ -230,8 +230,8 @@ export default function DeploymentTemplateOverrideForm({
                 : await api(+appId, +envId, payload)
             if (deploymentTemplateResp.result?.isLockConfigError && !saveEligibleChanges) {
                 // checking if any locked changes and opening drawer to show eligible and locked ones
-                setLockedOverride(deploymentTemplateResp.result?.lockedOverride)
-                setDisableSaveEligibleChanges(deploymentTemplateResp.result?.disableSaveEligibleChanges)
+                setLockedOverride(deploymentTemplateResp.result.lockedOverride)
+                setDisableSaveEligibleChanges(deploymentTemplateResp.result.disableSaveEligibleChanges)
                 handleLockedDiffDrawer(true)
                 return
             }
@@ -242,10 +242,10 @@ export default function DeploymentTemplateOverrideForm({
 
             if (envOverrideValuesWithBasic) {
                 editorOnChange(YAML.stringify(envOverrideValuesWithBasic, { indent: 2 }), true)
-            } else {
+            } else if (deploymentTemplateResp.result?.envOverrideValues) {
                 dispatch({
                     type: DeploymentConfigStateActionTypes.tempFormData,
-                    payload: YAML.stringify(deploymentTemplateResp.result?.envOverrideValues),
+                    payload: YAML.stringify(deploymentTemplateResp.result.envOverrideValues),
                 })
             }
             toast.success(

diff --git a/src/components/app/details/appDetails/AppDetails.tsx b/src/components/app/details/appDetails/AppDetails.tsx
@@ -333,9 +333,7 @@ export const Details: React.FC<DetailsType> = ({
                     }
                 },
             )
-            .catch((error) => {
-              showError(error)
-            })
+            .catch()
         },
         [
             params.appId,

diff --git a/src/components/app/details/main.tsx b/src/components/app/details/main.tsx
@@ -109,9 +109,7 @@ export default function AppDetailsPage({ isV2 }: AppDetailsProps) {
             _groupFilterOption.sort(sortOptionsByLabel)
             setGroupFilterOptions(_groupFilterOption)
           }
-        } catch (error) {
-          showError(error)
-        }
+        } catch {}
         setAppListLoading(false)
     }
 
@@ -132,9 +130,7 @@ export default function AppDetailsPage({ isV2 }: AppDetailsProps) {
               .sort(sortOptionsByLabel),
             )
           }
-        } catch (error) {
-          showError(error)
-        }
+        } catch {}
         setAppListLoading(false)
     }
 

diff --git a/src/components/app/details/triggerView/TriggerView.tsx b/src/components/app/details/triggerView/TriggerView.tsx
@@ -171,9 +171,7 @@ class TriggerView extends Component<TriggerViewProps, TriggerViewState> {
             const _isDefaultConfig = response.result.is_default_configured
             this.setState({ configs: isConfigPresent, isDefaultConfigPresent: _isDefaultConfig })
         })
-        .catch((error) => {
-          showError(error)
-        })
+        .catch()
     }
 
     getWorkflows = (isFromOnMount?: boolean) => {

diff --git a/src/components/common/helpers/Helpers.tsx b/src/components/common/helpers/Helpers.tsx
@@ -1,4 +1,4 @@
-import React, { useState, useEffect, useCallback, useRef, useMemo, RefObject, useLayoutEffect } from 'react'
+import React, { useState, useEffect, useCallback, useRef, useMemo } from 'react'
 import {
     showError,
     useThrottledEffect,

diff --git a/src/components/deploymentConfig/DeploymentTemplateView/DeploymentConfigFormCTA.tsx b/src/components/deploymentConfig/DeploymentTemplateView/DeploymentConfigFormCTA.tsx
@@ -74,7 +74,7 @@ export default function DeploymentConfigFormCTA({
                 const deploymentTemplateResp = await checkForProtectedLockedChanges()
                 if (deploymentTemplateResp.result?.isLockConfigError) {
                     setShowLockedDiffForApproval(true)
-                    setLockedOverride(deploymentTemplateResp.result?.lockedOverride)
+                    setLockedOverride(deploymentTemplateResp.result.lockedOverride)
                     handleLockedDiffDrawer(true)
                 } else {
                     setShowLockedDiffForApproval(false)

diff --git a/src/components/login/Login.tsx b/src/components/login/Login.tsx
@@ -61,9 +61,7 @@ export default class Login extends Component<LoginProps, LoginFormState> {
                 loginList: list,
             })
         })
-        .catch(error => {
-          showError(error)
-        })
+        .catch()
         if (typeof Storage !== 'undefined') {
             if (localStorage.isDashboardAccessed) {
                 return

diff --git a/src/components/v2/appDetails/AppDetails.component.tsx b/src/components/v2/appDetails/AppDetails.component.tsx
@@ -1,7 +1,7 @@
 import React, { useEffect, useRef, useState } from 'react'
 import './appDetails.scss'
 import { useLocation, useParams } from 'react-router'
-import { DeploymentAppTypes, Progressing, showError } from '@devtron-labs/devtron-fe-common-lib'
+import { DeploymentAppTypes, Progressing } from '@devtron-labs/devtron-fe-common-lib'
 import { AppDetailsComponentType, AppType } from './appDetails.type'
 import IndexStore from './index.store'
 import EnvironmentStatusComponent from './sourceInfo/environmentStatus/EnvironmentStatus.component'
@@ -105,9 +105,7 @@ const AppDetailsComponent = ({
                 }
             },
         )
-        .catch((error) => {
-          showError(error)
-        })
+        .catch()
     }
 
     const processDeploymentStatusData = (deploymentStatusDetailRes: DeploymentStatusDetailsType): void => {