Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: redirection to chart store and hide scope variables in EA only mode #2079

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

eshankvaish
Copy link
Contributor

@eshankvaish eshankvaish commented Sep 23, 2024

Description

fix: redirection to chart store and hide scope variables in EA only mode

Fixes https://github.com/devtron-labs/sprint-tasks/issues/972

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@eshankvaish eshankvaish self-assigned this Sep 23, 2024
@github-actions github-actions bot added the PR:Issue-verification-failed PR:Issue-verification-failed label Sep 23, 2024
RohitRaj011
RohitRaj011 previously approved these changes Sep 24, 2024
Copy link

sonarcloud bot commented Sep 24, 2024

@eshankvaish eshankvaish added PR:Ready-to-Review PR:Ready-to-Review and removed PR:Issue-verification-failed PR:Issue-verification-failed labels Sep 24, 2024
@eshankvaish eshankvaish changed the title fix: redirection to chart store and hide scope variables in EA only mode chore: fix: redirection to chart store and hide scope variables in EA only mode Sep 24, 2024
@eshankvaish eshankvaish merged commit 7d86138 into main Sep 24, 2024
11 of 15 checks passed
@eshankvaish eshankvaish deleted the fix/ea-issues branch September 24, 2024 05:59
@eshankvaish eshankvaish changed the title chore: fix: redirection to chart store and hide scope variables in EA only mode fix: redirection to chart store and hide scope variables in EA only mode Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR:Ready-to-Review PR:Ready-to-Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants