Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: common out node listing and K8sResourceList into K8sResourceList #2216

Merged
merged 15 commits into from
Nov 22, 2024
Merged
Show file tree
Hide file tree
Changes from 13 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -66,16 +66,13 @@ src/components/ClusterNodes/ClusterEvents.tsx
src/components/ClusterNodes/ClusterManifest.tsx
src/components/ClusterNodes/ClusterNodeEmptyStates.tsx
src/components/ClusterNodes/ClusterOverview.tsx
src/components/ClusterNodes/ColumnSelector.tsx
src/components/ClusterNodes/NodeActions/CordonNodeModal.tsx
src/components/ClusterNodes/NodeActions/DeleteNodeModal.tsx
src/components/ClusterNodes/NodeActions/DrainNodeModal.tsx
src/components/ClusterNodes/NodeActions/EditTaintsModal.tsx
src/components/ClusterNodes/NodeActions/NodeActionsMenu.tsx
src/components/ClusterNodes/NodeActions/validationRules.ts
src/components/ClusterNodes/NodeDetails.tsx
src/components/ClusterNodes/NodeDetailsList.tsx
src/components/ClusterNodes/NodeListSearchFilter.tsx
src/components/ClusterNodes/__tests__/ClusterManifest.test.tsx
src/components/ClusterNodes/__tests__/NodeList.test.tsx
src/components/ClusterNodes/constants.ts
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"private": true,
"homepage": "/dashboard",
"dependencies": {
"@devtron-labs/devtron-fe-common-lib": "1.1.1",
"@devtron-labs/devtron-fe-common-lib": "1.0.9-beta-1",
"@esbuild-plugins/node-globals-polyfill": "0.2.3",
"@rjsf/core": "^5.13.3",
"@rjsf/utils": "^5.13.3",
Expand Down
34 changes: 0 additions & 34 deletions src/components/CIPipelineN/ciPipeline.utils.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -172,40 +172,6 @@ export const outputFormatSelectStyle = {
}),
}

export const containerImageSelectStyles = {
...baseSelectStyles,
control: (base, state) => ({
...base,
border: '1px solid var(--N200)',
boxShadow: 'none',
minHeight: 'auto',
borderRadius: '4px',
height: '32px',
fontSize: '12px',
pointerEvents: 'auto',
cursor: state.isDisabled ? 'not-allowed' : 'pointer',
}),
valueContainer: (base, state) => ({
...base,
color: 'var(--N900)',
background: 'var(--N50) !important',
padding: '0px 10px',
display: 'flex',
height: '30px',
borderTopLeftRadius: '4px',
borderBottomLeftRadius: '4px',
fontSize: '12px',
width: '100px',
whiteSpace: 'nowrap',
}),
indicatorsContainer: (base, state) => ({
...base,
background: 'var(--N50) !important',
borderTopRightRadius: '4px',
borderBottomRightRadius: '4px',
}),
}

export const CiPipelineSourceTypeBaseOptions = [
{
label: 'Branch Fixed',
Expand Down
1 change: 0 additions & 1 deletion src/components/ClusterNodes/ClusterNodeEmptyStates.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
*/

import { GenericFilterEmptyState } from '@devtron-labs/devtron-fe-common-lib'
import React from 'react'

export default function ClusterNodeEmptyState({
title,
Expand Down
182 changes: 0 additions & 182 deletions src/components/ClusterNodes/ColumnSelector.tsx

This file was deleted.

Loading
Loading