Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]: PR for viewing diff #2245

Closed
wants to merge 80 commits into from
Closed

[WIP]: PR for viewing diff #2245

wants to merge 80 commits into from

Conversation

AbhishekA1509
Copy link
Member

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

RohitRaj011 and others added 30 commits November 14, 2024 11:48
@RohitRaj011
fix: AppListFilters - Filter Dropdown - when timer updates, filter se…
f8b9717 
…lection gets cleared fix
@RohitRaj011
fix: ChartUsedCard - color update
efa2989
@arunjaindev
feat: replace hibernate modal with confirmation dialog
b2425ae
@arunjaindev
chore: add prop handleClose
d419509
@shivani170
Merge branch 'develop' into fix/misc-bug-fixes
028391a
@arunjaindev
Chore: version bump
3030d5f
@shivani170
chore: chart UI fixes
f61456e
@shivani170
chore: removed unused code
2bbc470
@Elessar1802
refactor: remove nodeDetailsList and handle node listing through k8sR…
5459c79 
…esourceList

BREAKING CHANGES: appliedColumns entry in local storage
@Elessar1802
Merge branch 'develop' of github.com:devtron-labs/dashboard into refa…
e9477cd 
…ctor/node-details-list
@shivani170
chore: revert code
8bd324b
@shivani170
chore: code formatting
5a134ad
@eshankvaish
Merge branch 'develop' of github.com:devtron-labs/dashboard into feat…
c46ba18 
…/react-diff-viewer
@eshankvaish
chore: bump common lib
0a3d19e
@eshankvaish
feat: update color for diff view
79dee60
@eshankvaish
chore: bump common
aa82331
@Elessar1802
fix: check for old appliedColumns format
e3237b4
@eshankvaish
chore: bump common lib
1a5e442
@arunjaindev
feat: remove markdown and marked from dashboard
60ffc9a
@arunjaindev
chore: revert target url
3f30835
@arunjaindev
feat: helm charts sidebar ui fixes
b2d1074
@shivani170
chore: document body replaced with ref
6881766
@Elessar1802
fix: add error icon for errors column & colors in status column
0a67522
@shivani170
Merge pull request #2212 from devtron-labs/fix/misc-bug-fixes
d2fde88 
fix: misc bug fixes
@Elessar1802
refactor: use select picker in column selector & minor css improvements
e81f300
@eshankvaish
Merge branch 'develop' of github.com:devtron-labs/dashboard into chor…
6acb4d3 
…e/rc-23-dev-sync
@eshankvaish
chore: version bump
f90fbba
@Elessar1802
fix: review comments
ee17391
@eshankvaish
Merge branch 'main' of github.com:devtron-labs/dashboard into chore/r…
fc4fba6 
…c-23-dev-sync
@eshankvaish
Merge pull request #2226 from devtron-labs/chore/rc-23-dev-sync
5e60ea0 
chore: sync develop with main (rc-23)
arunjaindev and others added 25 commits November 25, 2024 18:08
@arunjaindev
chore: rename backdrop id
4963af4
@arunjaindev
chore: background size for status
8d14eae
@arunjaindev
chore: version bump
62f2645
@arunjaindev
Merge pull request #2221 from devtron-labs/feat/marked-version-bump
5f35bbc 
feat: marked version bump
@Elessar1802
fix: k8sResourceList empty before selectedResource is set
2ce87c6
@Elessar1802
fix: isOpen is false on mount for k8s tab component
2b302d4
@Elessar1802
Merge branch 'main' of github.com:devtron-labs/dashboard into fix/nod…
f414119 
…e-permissions
@arunjaindev
feat: add backdrop class
1f132bf
@arunjaindev
Merge branch 'develop' of https://github.com/devtron-labs/dashboard i…
09e7bea 
…nto feat/confirmation-modal
@arunjaindev
chore: version bump
9d5b35f
@arunjaindev
chore: version bump
418782c
@Elessar1802
fix: dont render tab components unless tabs get initialized
06f710d
@Elessar1802
Merge pull request #2239 from devtron-labs/fix/node-permissions-tabs
e2d69c0 
fix: dont render tab components unless tabs get initialized
@Elessar1802
Merge branch 'develop' of github.com:devtron-labs/dashboard into fix/…
31d499b 
…node-permissions
@Elessar1802
chore: common-lib version bump
d028f93
@Elessar1802
fix: update terminal tab dynamic title after cluster name fetch
e6cec09
@Elessar1802
Merge branch 'main' of github.com:devtron-labs/dashboard into fix/nod…
70e7623 
…e-permissions
@arunjaindev
chore: version bump
86202ca
@Elessar1802
fix: review comments
e6eb8ae
@Elessar1802
chore: common-lib version bump
7d20f85
@Elessar1802
Merge pull request #2240 from devtron-labs/fix/node-permissions
10da613 
fix: node permissions
@eshankvaish
fix: force flag instead of forceDelete in installed charts
6edf20f
@eshankvaish
Merge pull request #2243 from devtron-labs/fix/helm-app-force-delete
74f5206 
fix: force flag instead of forceDelete in installed charts
@arunjaindev
Merge branch 'develop' of https://github.com/devtron-labs/dashboard i…
67d776f 
…nto feat/confirmation-modal
@arunjaindev
Merge pull request #2211 from devtron-labs/feat/confirmation-modal
2cf2702 
feat: replace hibernate modal with confirmation modal
@github-actions github-actions bot added the PR:Issue-verification-failed PR:Issue-verification-failed label Nov 29, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikramdevtron vikramdevtron Awaiting requested review from vikramdevtron vikramdevtron is a code owner

@vivek-devtron vivek-devtron Awaiting requested review from vivek-devtron vivek-devtron is a code owner

Assignees
No one assigned
Labels
PR:Issue-verification-failed PR:Issue-verification-failed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AbhishekA1509 @RohitRaj011 @arunjaindev @shivani170 @Elessar1802 @eshankvaish