Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support adding expiration later on #48

Open
CodeProKid opened this issue Nov 17, 2017 · 0 comments
Open

Support adding expiration later on #48

CodeProKid opened this issue Nov 17, 2017 · 0 comments
Assignees
Labels
Milestone

Comments

@CodeProKid
Copy link
Collaborator

Should add support for adding an expiration to a registered transient after registering it once already. The use case would be: someone registers a transient without an expiration, but later on decides that it should have an expiration. Since the data shape, and how the data is stored changes slightly when a transient has an expiration, some weirdness could happen when adding the expiration after the data has been saved.

If a transient is registered with an expiration, but the data is not in the correct shape, we should just regenerate that data on the spot to be in the correct shape, so that it is correct moving forward.

Conversely, this should also work going the other way (a registered transient that has an expiration, but you want to remove it).

@CodeProKid CodeProKid added the bug label Nov 17, 2017
@CodeProKid CodeProKid added this to the 1.3.0 milestone Nov 17, 2017
@CodeProKid CodeProKid self-assigned this Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant