Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ordered <ol> and Unordered <ul> List view doesn't support the differentiation in the HTML diff #5

Open
ankitstudent09 opened this issue Nov 15, 2018 · 1 comment

Comments

@ankitstudent09
Copy link
Contributor

An ordered and Unordered list is not supported in HTML diff Library when I am comparing two different HTML code.

Below I am stating an example which will brief you as follows:-

old html Code with unordered list view

<ul><li>Coffee</li><li>Tea</li><li>Milk</li></ul>

new html Code with ordered list view

<ol><li>Coffee</li><li>Tea</li><li>Milk</li></ol>

It is not showing up any difference when I am using the same library.

For reference I am pasting the sceenshot regarding the above example.
no-difference

Please review and Let us know your thoughts and suggestions over it.

@dfoverdx
Copy link
Owner

To be honest, I don't actually understand the code in this project. I merely ported it from the C# HTMLDiff.Net project.

I also don't quite understand what you want it to do. Should it wrap the whole list in <ins class="diffmod"> and <del class="diffmod"> tags?

If you want to fix it yourself and create a pull request, I'd be happy to approve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants