Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Storing values larger than 2 GB #2040

Open
mitar opened this issue Dec 31, 2023 · 6 comments
Open

[FEATURE]: Storing values larger than 2 GB #2040

mitar opened this issue Dec 31, 2023 · 6 comments
Labels
kind/feature Something completely new we should consider.

Comments

@mitar
Copy link
Contributor

mitar commented Dec 31, 2023

Have you tried Badger before this proposal? and did not find anything similar?

None

What you wanted to do.

I wanted to set ValueLogFileSize to 6 GB.

What you actually did.

Called opts.WithValueLogFileSize(6 * 1024 * 1024 * 1024).

Why wasn't it great, with examples.

I got error Invalid ValueLogFileSize, must be in range [1MB, 2GB).

Additional information.

Could this limit be lifted on 64bit systems? It seems to me that this is just to support mmap on 32 bit systems and there is really no design limitation why not to support larger values? On my system, I have:

$ grep -m1 "address sizes" /proc/cpuinfo 
address sizes	: 39 bits physical, 48 bits virtual

So a bit less than 2^47 (128 TiB) could be the max limit for mmap on my system.

@mitar mitar added the kind/feature Something completely new we should consider. label Dec 31, 2023
@simon28082
Copy link
Contributor

I have the same problem, 2G is too little for me, we need more than 8G

@nathanhack
Copy link

Same here

Copy link

This issue has been stale for 60 days and will be closed automatically in 7 days. Comment to keep it open.

@github-actions github-actions bot added the Stale label Jul 13, 2024
@mitar
Copy link
Contributor Author

mitar commented Jul 13, 2024

Still relevant.

@github-actions github-actions bot removed the Stale label Jul 14, 2024
Copy link

This issue has been stale for 60 days and will be closed automatically in 7 days. Comment to keep it open.

@github-actions github-actions bot added the Stale label Sep 12, 2024
@mitar
Copy link
Contributor Author

mitar commented Sep 12, 2024

Still relevant.

@github-actions github-actions bot removed the Stale label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Something completely new we should consider.
Development

No branches or pull requests

3 participants