Catch to prevent push-receiver crash on disconnect (#1540)

* Catch to prevent push-receiver crash on disconnect * Add changeset --------- Co-authored-by: Tom Sightler <[email protected]> Co-authored-by: dgreif <[email protected]>
dgreif · Dec 2, 2024 · 06a3bcb · 06a3bcb
1 parent 68643f5
commit 06a3bcb
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/.changeset/shy-needles-stare.md b/.changeset/shy-needles-stare.md
@@ -0,0 +1,6 @@
+---
+'homebridge-ring': patch
+'ring-client-api': patch
+---
+
+Handle errors when connecting to push notification service
diff --git a/packages/ring-client-api/api.ts b/packages/ring-client-api/api.ts
@@ -291,6 +291,17 @@ export class RingApi extends Subscribed {
         }
       }),
     )
+    pushReceiver.on('ON_DISCONNECT', () => {
+      pushReceiver.whenReady.catch((e) => {
+        logError(
+          'Connection to the push notification server has failed unexpectedly',
+        )
+        logError(
+          'If this happens repeatedly, verify connections to TCP/5228 are allowed and that DNS Adblock rules allow gtalk.google.com',
+        )
+        logError(e.message)
+      })
+    })
 
     try {
       await pushReceiver.connect()