Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional information field for data model? #25

Closed
robcast opened this issue Nov 10, 2022 · 2 comments
Closed

Additional information field for data model? #25

robcast opened this issue Nov 10, 2022 · 2 comments
Milestone

Comments

@robcast
Copy link
Contributor

robcast commented Nov 10, 2022

Should we add a string notes field for additional information to the data model?

This field would be separate from the label field, which is just a printable representation of the date (I assume). The additional information field could contain information from the original source that is not represented in the date object, like "On a Sunday morning".

One could argue that this field does not have to be in the date data model but it should be in the data model of the application that uses the date.

Our ISMI data (see #17) currently has such a field and we need to keep the information in the migration.

@rlskoeser
Copy link
Member

From the discussion at our kickoff meeting, I was thinking that the label field would be optional additional information or a name for the date or time period (e.g., something like "The Renaissance" or maybe "Easter 1919") — so maybe the text you have could fit there?

@rlskoeser rlskoeser added this to the 1.0 release milestone Jun 6, 2024
@rlskoeser
Copy link
Member

I'm going to close this issue because our existing label field is meant for exactly this purpose - it's an optional field for additional information or description of the date. We can think more about what we want to do with this field; it should probably be integrated into some of the string methods, but I'm not sure how we'd decide when/if you want the label and when you don'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants