Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a function to help with recursion #12

Open
dhhagan opened this issue Dec 21, 2016 · 5 comments
Open

Add a function to help with recursion #12

dhhagan opened this issue Dec 21, 2016 · 5 comments

Comments

@dhhagan
Copy link
Owner

dhhagan commented Dec 21, 2016

make it easier to recursively grab all data if there is more than 1 page..

@biggydbs
Copy link

biggydbs commented Oct 4, 2017

I would like to solve this issue.

@dhhagan
Copy link
Owner Author

dhhagan commented Oct 4, 2017

@biggydbs Awesome! Let me know if you need any help or have any questions.

@biggydbs
Copy link

biggydbs commented Oct 4, 2017

Yes, I tried to run all the tests, but some failed (tests.openaq_test.SetupTestCase -> test_pandasize)

@dhhagan
Copy link
Owner Author

dhhagan commented Oct 5, 2017

That's associated with the pandasize decorator that converts the output to a Pandas DataFrame. The solution should probably be able to deal with both (or I can change the decorator).

@dhhagan
Copy link
Owner Author

dhhagan commented Jan 24, 2018

Hey @biggydbs I just fixed some issues associated with the pandasize decorator; apparently some breaking changes were made to the OpenAQ API that I wasn't aware of (the API calls started failing when keyword arguments were sent that weren't allowed, whereas previously they were silently dropped). I will be merging those changes into master later today (currently are on branch dev-pc); I would love for you to merge in your changes if that was the only issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants