Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: s/replaceAll/replace/ #15591

Merged
merged 1 commit into from
Nov 3, 2023
Merged

ci: s/replaceAll/replace/ #15591

merged 1 commit into from
Nov 3, 2023

Conversation

tonsV2
Copy link
Contributor

@tonsV2 tonsV2 commented Nov 3, 2023

@tonsV2 tonsV2 requested a review from radnov November 3, 2023 10:03
@tonsV2 tonsV2 enabled auto-merge (squash) November 3, 2023 10:04
Copy link

sonarcloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #15591 (00828e3) into 2.39 (886690f) will increase coverage by 6.19%.
Report is 106 commits behind head on 2.39.
The diff coverage is 67.26%.

@@             Coverage Diff              @@
##               2.39   #15591      +/-   ##
============================================
+ Coverage     58.58%   64.77%   +6.19%     
- Complexity    25817    28684    +2867     
============================================
  Files          3207     3212       +5     
  Lines        121397   121860     +463     
  Branches      14158    14218      +60     
============================================
+ Hits          71118    78938    +7820     
+ Misses        44340    36434    -7906     
- Partials       5939     6488     +549     
Flag Coverage Δ
integration 48.58% <34.53%> (-0.02%) ⬇️
integration-h2 33.98% <22.88%> (?)
unit 29.57% <39.51%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...main/java/org/hisp/dhis/appmanager/AppManager.java 100.00% <ø> (ø)
...src/main/java/org/hisp/dhis/category/Category.java 65.21% <100.00%> (ø)
...ava/org/hisp/dhis/common/BaseAnalyticalObject.java 70.95% <100.00%> (+5.81%) ⬆️
...a/org/hisp/dhis/common/BaseIdentifiableObject.java 80.20% <100.00%> (+1.37%) ⬆️
...s-api/src/main/java/org/hisp/dhis/common/Grid.java 0.00% <ø> (ø)
.../src/main/java/org/hisp/dhis/common/QueryItem.java 68.66% <100.00%> (ø)
...isp/dhis/dataapproval/DataApprovalPermissions.java 91.66% <ø> (+22.43%) ⬆️
...rc/main/java/org/hisp/dhis/feedback/ErrorCode.java 100.00% <100.00%> (ø)
...src/main/java/org/hisp/dhis/period/PeriodType.java 85.45% <100.00%> (+1.91%) ⬆️
...rg/hisp/dhis/resourcetable/ResourceTableStore.java 100.00% <ø> (+100.00%) ⬆️
... and 104 more

... and 551 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9d7ab6...00828e3. Read the comment docs.

@tonsV2 tonsV2 merged commit 020cbaa into 2.39 Nov 3, 2023
12 checks passed
@tonsV2 tonsV2 deleted the feature/replace_2.39 branch November 3, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants