Replies: 1 comment
-
+1 from me. I've noticed during cypress tests that our modal is quite inaccessible. I think it would be good to wrap up this (more meta) discussion first: #238. If we decide on an overarching strategy, we could start planning & fixing the accessibility issues. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Accessible modals
This is a summary of accessibility issues with our modal component.
Issues
Keyboard accessibility
Screenreader accessibility
role="dialog"
andaria-modal
attribute should be set fix(modal): add ARIA dialog role to modals ui#545aria-labelledby
attribute (and optionallyaria-describedby
) should be setExample implementation of fully keyboard accessible modal
https://www.w3.org/TR/wai-aria-practices-1.1/examples/dialog-modal/dialog.html#ex_label
Resources
Beta Was this translation helpful? Give feedback.
All reactions