-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New colResize Option Is Awesome! But Requires Care When Using With colReorder #5
Comments
I ran into the same problem,can someone please give me a solution for this? |
A possible solution would be to temporarily disable the colReorder plugin while the resize is in progress.
|
Even after disabling column reorder, the column size resets after moving any column. |
@porrey. I just ran in demo above and did not find that to be case. Column size stayed as adjusted after performing column reorder. |
@dhobi. A belated thank you! |
Is state saving on or off? |
On, I believe. You can see the code just by right click / view source. |
The issue occurs when a column width is set in This video demonstrates the behavoir: https://youtu.be/KOK81An73_0 |
ouch. that one will have to be for @dhobi. c |
one thought. you might try setting column widths in style sheet instead of dt. |
@porrey Do you have a minimal example to reproduce the issue? As the plugin sets the column.width property and the dom (th).outerWidth() I have to see what exactly is going on. Is the table reinitialized on column drag? |
Started working on extracting the example that mimics my actual application (it uses server side processing). I am unable to get the column resizing to work but here is the link. Work in progress... |
Another note, the ColResize library must be initialized before ColReorder, or else the event listener will call ColReorder first, thus the flag set does not work |
For those facing this problem: In order to make sure that colResize is registered before colReorder we have to tweak the event logic slightly. Here is the part I added:
It was added after the "preInit" event handler: With this change I am able to disable "reorder" plugin in "onResizeStart" and enable it again in "onResizeEnd":
Dealing with the event queue of jquery is not the nicest solution but it works. Currently I don't see any other solution as the reorder plugin does not provide any functionality that would help. |
I find the new colResize plugin by Daniel Hobi awesome!
Allan mentions it in What's New. Although the free demo has expired, the plugin definitely works.
Minor detail, but when using in conjunction with colReorder, the user needs to resize only enough to not drag target column too far into next column, else the colReorder kicks in.
Here's link to my simple demo.
I tried mitigating with colReorder.realtime() set to false, but to no avail.
Might be better for end users to suppress colReorder while colResize is engaged. I will try to do this with jQuery .on action, but in mean time, heads-up.
Will send separate note to Daniel as well.
But again, very welcomed addition to dt!
The text was updated successfully, but these errors were encountered: