Buttom of item text lables are being cut off for CJK font

[teddy516]

The previous version 1.4.1 text display was perfect, but the new version has this problem, I hope it can be fixed, thank you.

[AJenbo]

Can you please be more specific about what the error is, maybe show a comparison

[teddy516]

Compare text labels for potions on the ground

[DakkJaniels]

Are you saying the bottom of the text is getting cut off? Probably would have been helpful if you used the same potions.

[teddy516]

[teddy516]

In addition, the font size displayed in the status bar at the bottom is not appropriate.

[AJenbo]

Please give us an idea of what is expected, most of us do not read cjk, so "not right" is practically impossible for us to fix with out saying exactly what needs to be changed for it to be corrected.

[teddy516]

I'm sorry, I'm just an ordinary player, I don't know what the specific reason is, I can't understand why the text will be abnormal when I update the new version, I only hope to restore the normal text display state of 1.4.1, if I know programming, maybe I can find out the difference between the two versions of the font, so I can only ask the professionals here. Maybe it could be done by resizing the font or changing it to another font?

[DakkJaniels]

It's not about the programming. We (or at least I) don't understand what the characters are supposed to look like.

That being said, I think it's more clear in the potion comparison that the bottom of the characters are getting cut off in 1.5.1.

[DakkJaniels]

If you look at the two pictures, you can see in 1.4.1 that the text is going beyond the bottom of the box and still rendering, but in 1.5.1 the text is cut off a pixel or two from the bottom of the box:

Edit, it also looks like the top of the text in 1.5.1 is rendering outside the top of the box which matches 1.4.1, I think.

[AJenbo]

Maybe it could be done by resizing the font or changing it to another font?

The CJK font is already the minimal size possible for representing legible CJK letters.

If you look at the two pictures, you can see in 1.4.1 that the text is going beyond the bottom of the box and still rendering, but in 1.5.1 the text is cut off a pixel or two from the bottom of the box:

Sounds like the box simply needs to be higher when displaying CJK texts

[AJenbo]

@teddy516 like Dakk said we do not expect you to tell us what technical changes are needed, but you do need to explain to us what "appropriate" looks like.

In addition, the font size displayed in the status bar at the bottom is not appropriate.

I have no idea what isn't appropriate about this, you might as well have shown me The Monalisa and said it wasn't done right by the artist. I don't know if she was actually supposed to look like an old man or there should be snow in the background.

[teddy516]

good

bad

[glebm]

I've sent a fix for the item labels in #6894. With the fix it is better than 1.4.1 because the label no longer overflows the box, instead the box is made larger for CJK.

The info box (panel at the bottom of the screen) is a known issue and was similar to this in 1.4.1 as well (there simply isn't enough space) but I've made it slightly less bad in #6895

Basically what changed from 1.4 to 1.5 is that the text is now clipped to the box it's drawn in. This bugfix exposed some boxes that were too small.

[glebm]

Item labels are now fixed, info box issue is known and is tracked in #3549

[AJenbo]

Feel free to put it in the 1.5 branch as well, I have a cold atm so will be a bit spotty atm